PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libcamera: controls: Remove ControlInfo::id

Browse Source 
The ControlInfo id member is only used in the toString() method of the
class, and nowhere else externally. The same way that ControlValue
doesn't store a ControlId, ControlInfo shouldn't. Remove it.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
This commit is contained in:
Laurent Pinchart
2019-09-28 14:13:44 +03:00
parent 5a952df386
commit f1ab117e81
5 changed files with 8 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/libcamera/controls.h
View File

@@ -98,17 +98,15 @@ private:
class ControlInfo
{
public:
explicit ControlInfo(const ControlId &id, const ControlValue &min = 0,
explicit ControlInfo(const ControlValue &min = 0,
const ControlValue &max = 0);
const ControlId &id() const { return id_; }
const ControlValue &min() const { return min_; }
const ControlValue &max() const { return max_; }
std::string toString() const;
private:
const ControlId &id_;
ControlValue min_;
ControlValue max_;
};