From ef146614877ef1739b5b3bb9b7937b5a71db04f5 Mon Sep 17 00:00:00 2001 From: Stefan Klug Date: Tue, 25 Nov 2025 17:28:31 +0100 Subject: [PATCH] pipeline: rkisp1: Drop rawFormat variable MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In raw mode we know there is only a single configuration so there is no need to iterate over all configurations to find the format. Drop that. Signed-off-by: Stefan Klug Reviewed-by: Umang Jain Reviewed-by: Barnabás Pőcze Reviewed-by: Paul Elder --- src/libcamera/pipeline/rkisp1/rkisp1.cpp | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp index 89b6ab30..36055ac7 100644 --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp @@ -677,21 +677,16 @@ CameraConfiguration::Status RkISP1CameraConfiguration::validate() } /* Select the sensor format. */ - PixelFormat rawFormat; Size maxSize; for (const StreamConfiguration &cfg : config_) { - const PixelFormatInfo &info = PixelFormatInfo::info(cfg.pixelFormat); - if (info.colourEncoding == PixelFormatInfo::ColourEncodingRAW) - rawFormat = cfg.pixelFormat; - maxSize = std::max(maxSize, cfg.size); } std::vector mbusCodes; - if (rawFormat.isValid()) { - mbusCodes = { rawFormats.at(rawFormat) }; + if (isRaw) { + mbusCodes = { rawFormats.at(config_[0].pixelFormat) }; } else { std::transform(rawFormats.begin(), rawFormats.end(), std::back_inserter(mbusCodes),