libcamera: v4l2_device: Return a unique pointer from fromEntityName()
The fromEntityName() function returns a pointer to a newly allocated V4L2Device instance, which must be deleted by the caller. This opens the door to memory leaks. Return a unique pointer instead, which conveys the API semantics better than a sentence in the documentation. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
This commit is contained in:
@@ -24,15 +24,10 @@ RkISP1Path::RkISP1Path(const char *name, const Span<const PixelFormat> &formats,
|
||||
const Size &minResolution, const Size &maxResolution)
|
||||
: name_(name), running_(false), formats_(formats),
|
||||
minResolution_(minResolution), maxResolution_(maxResolution),
|
||||
video_(nullptr), link_(nullptr)
|
||||
link_(nullptr)
|
||||
{
|
||||
}
|
||||
|
||||
RkISP1Path::~RkISP1Path()
|
||||
{
|
||||
delete video_;
|
||||
}
|
||||
|
||||
bool RkISP1Path::init(MediaDevice *media)
|
||||
{
|
||||
std::string resizer = std::string("rkisp1_resizer_") + name_ + "path";
|
||||
|
||||
Reference in New Issue
Block a user