PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libcamera: controls: Use explicit 32-bit integer types

Browse Source 
Make the control API more explicit when dealing with integer controls by
specifying the size. We already do so for 64-bit integers, using int64_t
and ControlTypeInteger64, do the same for 32-bit integers.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
This commit is contained in:
Laurent Pinchart
2019-09-28 00:27:33 +03:00
parent 224ef9776a
commit dd37ef784e
7 changed files with 46 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libcamera/pipeline/uvcvideo.cpp
+5 -5
View File
@@ -235,24 +235,24 @@ int PipelineHandlerUVC::processControls(UVCCameraData *data, Request *request)
switch (ci->id()) {
case Brightness:
controls.add(V4L2_CID_BRIGHTNESS, value.get<int>());
controls.add(V4L2_CID_BRIGHTNESS, value.get<int32_t>());
break;
case Contrast:
controls.add(V4L2_CID_CONTRAST, value.get<int>());
controls.add(V4L2_CID_CONTRAST, value.get<int32_t>());
break;
case Saturation:
controls.add(V4L2_CID_SATURATION, value.get<int>());
controls.add(V4L2_CID_SATURATION, value.get<int32_t>());
break;
case ManualExposure:
controls.add(V4L2_CID_EXPOSURE_AUTO, 1);
controls.add(V4L2_CID_EXPOSURE_ABSOLUTE, value.get<int>());
controls.add(V4L2_CID_EXPOSURE_ABSOLUTE, value.get<int32_t>());
break;
case ManualGain:
controls.add(V4L2_CID_GAIN, value.get<int>());
controls.add(V4L2_CID_GAIN, value.get<int32_t>());
break;
default: