PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

meson: Remove -Wno-unused-parameter

Browse Source 
We build libcamera with -Wno-unused-parameter and this doesn't cause
much issue internally. However, it prevents catching unused parameters
in inline functions defined in public headers. This can lead to
compilation warnings for applications compiled without
-Wno-unused-parameter.

To catch those issues, remove -Wno-unused-parameter and fix all the
related warnings with [[maybe_unused]].

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
This commit is contained in:
Laurent Pinchart
2019-10-27 00:36:13 +03:00
parent 3ef378731a
commit dbafe16da7
40 changed files with 95 additions and 73 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/android/camera3_hal.cpp
View File

@@ -32,20 +32,23 @@ static int hal_get_camera_info(int id, struct camera_info *info)
return cameraManager.getCameraInfo(id, info);
}
static int hal_set_callbacks(const camera_module_callbacks_t *callbacks)
static int hal_set_callbacks([[maybe_unused]] const camera_module_callbacks_t *callbacks)
{
cameraManager.setCallbacks(callbacks);
return 0;
}
static int hal_open_legacy(const struct hw_module_t *module, const char *id,
uint32_t halVersion, struct hw_device_t **device)
static int hal_open_legacy([[maybe_unused]] const struct hw_module_t *module,
[[maybe_unused]] const char *id,
[[maybe_unused]] uint32_t halVersion,
[[maybe_unused]] struct hw_device_t **device)
{
return -ENOSYS;
}
static int hal_set_torch_mode(const char *camera_id, bool enabled)
static int hal_set_torch_mode([[maybe_unused]] const char *camera_id,
[[maybe_unused]] bool enabled)
{
return -ENOSYS;
}