PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libcamera: framebuffer: Replace vector with span in constructor

Browse Source 
The FrameBuffer constructor takes a list of planes as an std::vector.
The caller may stores the planes in a different type of container,
resulting in the needless allocation of a temporary vector. Replace it
with a span.

Suggested-by: Daniel Rákos <daniel.rakos@rastergrid.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
This commit is contained in:
Laurent Pinchart
2025-08-12 19:48:36 +03:00
parent 5e351b89f0
commit b8d332cdcc
12 changed files with 38 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/libcamera/framebuffer.cpp
View File

@@ -130,9 +130,9 @@ LOG_DEFINE_CATEGORY(Buffer)
* \param[in] planes The frame memory planes
* \param[in] cookie Cookie
*/
FrameBuffer::Private::Private(const std::vector<Plane> &planes, uint64_t cookie)
: planes_(planes), cookie_(cookie), request_(nullptr),
isContiguous_(true)
FrameBuffer::Private::Private(Span<const Plane> planes, uint64_t cookie)
: planes_(planes.begin(), planes.end()), cookie_(cookie),
request_(nullptr), isContiguous_(true)
{
metadata_.planes_.resize(planes_.size());
}
@@ -315,7 +315,7 @@ ino_t fileDescriptorInode(const SharedFD &fd)
* \param[in] planes The frame memory planes
* \param[in] cookie Cookie
*/
FrameBuffer::FrameBuffer(const std::vector<Plane> &planes, unsigned int cookie)
FrameBuffer::FrameBuffer(Span<const Plane> planes, unsigned int cookie)
: FrameBuffer(std::make_unique<Private>(planes, cookie))
{
}
@@ -365,7 +365,7 @@ FrameBuffer::FrameBuffer(std::unique_ptr<Private> d)
* \brief Retrieve the static plane descriptors
* \return Array of plane descriptors
*/
const std::vector<FrameBuffer::Plane> &FrameBuffer::planes() const
Span<const FrameBuffer::Plane> FrameBuffer::planes() const
{
return _d()->planes_;
}