PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libcamera: framebuffer: Replace vector with span in constructor

Browse Source 
The FrameBuffer constructor takes a list of planes as an std::vector.
The caller may stores the planes in a different type of container,
resulting in the needless allocation of a temporary vector. Replace it
with a span.

Suggested-by: Daniel Rákos <daniel.rakos@rastergrid.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
This commit is contained in:
Laurent Pinchart
2025-08-12 19:48:36 +03:00
parent 5e351b89f0
commit b8d332cdcc
12 changed files with 38 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
include/libcamera/framebuffer.h
View File

@@ -58,11 +58,11 @@ public:
unsigned int length;
};
FrameBuffer(const std::vector<Plane> &planes, unsigned int cookie = 0);
FrameBuffer(Span<const Plane> planes, unsigned int cookie = 0);
FrameBuffer(std::unique_ptr<Private> d);
virtual ~FrameBuffer() {}
const std::vector<Plane> &planes() const;
Span<const Plane> planes() const;
Request *request() const;
const FrameMetadata &metadata() const;

3
include/libcamera/internal/framebuffer.h
View File

@@ -12,6 +12,7 @@
#include <utility>
#include <libcamera/base/class.h>
#include <libcamera/base/span.h>
#include <libcamera/fence.h>
#include <libcamera/framebuffer.h>
@@ -23,7 +24,7 @@ class FrameBuffer::Private : public Extensible::Private
LIBCAMERA_DECLARE_PUBLIC(FrameBuffer)
public:
Private(const std::vector<Plane> &planes, uint64_t cookie = 0);
Private(Span<const Plane> planes, uint64_t cookie = 0);
virtual ~Private();
void setRequest(Request *request) { request_ = request; }