PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libcamera: Don't ignore the return value of read() and write()

Browse Source 
The glibc read() and write() functions are defined with the
__warn_unused_result__ attribute when using FORTIFY_SOURCE. Don't ignore
their return value.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Laurent Pinchart
2019-04-29 02:08:11 +03:00
parent 5caa8a971d
commit b771196d91
2 changed files with 26 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libcamera/event_dispatcher_poll.cpp
+15 -2
View File
@@ -162,7 +162,14 @@ void EventDispatcherPoll::processEvents()
void EventDispatcherPoll::interrupt()
{
uint64_t value = 1;
write(eventfd_, &value, sizeof(value));
ssize_t ret = write(eventfd_, &value, sizeof(value));
if (ret != sizeof(value)) {
if (ret < 0)
ret = -errno;
LOG(Event, Error)
<< "Failed to interrupt event dispatcher ("
<< ret << ")";
}
}
short EventDispatcherPoll::EventNotifierSetPoll::events() const
@@ -214,7 +221,13 @@ void EventDispatcherPoll::processInterrupt(const struct pollfd &pfd)
return;
uint64_t value;
read(eventfd_, &value, sizeof(value));
ssize_t ret = read(eventfd_, &value, sizeof(value));
if (ret != sizeof(value)) {
if (ret < 0)
ret = -errno;
LOG(Event, Error)
<< "Failed to process interrupt (" << ret << ")";
}
}
void EventDispatcherPoll::processNotifiers(const std::vector<struct pollfd> &pollfds)