From af43c2f945c42cc7d111de63abed9ca3df830ca4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Barnab=C3=A1s=20P=C5=91cze?=
 <barnabas.pocze@ideasonboard.com>
Date: Thu, 6 Mar 2025 15:12:49 +0100
Subject: [PATCH] apps: common: options: Avoid copying in range based for loop
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The copy can trigger `-Wrange-loop-construct` and is not needed,
so use a reference to avoid it.

Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
---
 src/apps/common/options.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/apps/common/options.cpp b/src/apps/common/options.cpp
index cae193cc..b4ea1afe 100644
--- a/src/apps/common/options.cpp
+++ b/src/apps/common/options.cpp
@@ -887,7 +887,7 @@ OptionsParser::Options OptionsParser::parse(int argc, char **argv)
 
 	shortOptions[ids++] = ':';
 
-	for (const auto [opt, option] : optionsMap_) {
+	for (const auto &[opt, option] : optionsMap_) {
 		if (option->hasShortOption()) {
 			shortOptions[ids++] = opt;
 			if (option->argument != ArgumentNone)