libcamera: software_isp: Remove file seal TODO item
The file seal TODO item has been addressed. Remove it. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Milan Zamazal <mzamazal@redhat.com> Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> Tested-by: Milan Zamazal <mzamazal@redhat.com> Tested-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
This commit is contained in:
@@ -1,22 +1,3 @@
|
||||
1. Setting F_SEAL_SHRINK and F_SEAL_GROW after ftruncate()
|
||||
|
||||
>> SharedMem::SharedMem(const std::string &name, std::size_t size)
|
||||
>> : name_(name), size_(size), mem_(nullptr)
|
||||
>>
|
||||
>> ...
|
||||
>>
|
||||
>> if (ftruncate(fd_.get(), size_) < 0)
|
||||
>> return;
|
||||
>
|
||||
> Should we set the GROW and SHRINK seals (in a separate patch) ?
|
||||
|
||||
Yes, this can be done.
|
||||
Setting F_SEAL_SHRINK and F_SEAL_GROW after the ftruncate() call above could catch
|
||||
some potential errors related to improper access to the shared memory allocated by
|
||||
the SharedMemObject.
|
||||
|
||||
---
|
||||
|
||||
2. Reconsider stats sharing
|
||||
|
||||
>>> +void SwStatsCpu::finishFrame(void)
|
||||
|
||||
Reference in New Issue
Block a user