PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libcamera: framebuffer: Enable attaching additional data to FrameBuffer

Browse Source 
We cannot have a subclass of FrameBuffer because it is marked as final.
This adds a FrameBuffer constructor with FrameBuffer::Private. So we
can attach some additional resources with FrameBuffer through a
customized FrameBuffer::Private class.

Signed-off-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
This commit is contained in:
Hirokazu Honda
2021-11-24 03:39:46 +09:00
committed by Jacopo Mondi
parent 294663eece
commit 99bb610fd1
3 changed files with 25 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/libcamera/framebuffer.cpp
View File

@@ -119,6 +119,13 @@ FrameBuffer::Private::Private()
{
}
/**
* \brief FrameBuffer::Private destructor
*/
FrameBuffer::Private::~Private()
{
}
/**
* \fn FrameBuffer::Private::setRequest()
* \brief Set the request this buffer belongs to
@@ -237,8 +244,21 @@ ino_t fileDescriptorInode(const SharedFD &fd)
* \param[in] cookie Cookie
*/
FrameBuffer::FrameBuffer(const std::vector<Plane> &planes, unsigned int cookie)
: Extensible(std::make_unique<Private>()), planes_(planes),
cookie_(cookie)
: FrameBuffer(std::make_unique<Private>(), planes, cookie)
{
}
/**
* \brief Construct a FrameBuffer with an extensible private class and an array
* of planes
* \param[in] d The extensible private class
* \param[in] planes The frame memory planes
* \param[in] cookie Cookie
*/
FrameBuffer::FrameBuffer(std::unique_ptr<Private> d,
const std::vector<Plane> &planes,
unsigned int cookie)
: Extensible(std::move(d)), planes_(planes), cookie_(cookie)
{
metadata_.planes_.resize(planes_.size());