PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libcamera: geometry: Rename Rectangle fields

Browse Source 
The Rectangle class members that represents the rectangle horizontal and
vertical sizes are named 'w' and 'h', in contrast with the Size and
SizeRange classes which use 'width' and 'height', resulting in having to
look at class definition every time to know which names to use.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
This commit is contained in:
Jacopo Mondi
2020-04-20 10:32:45 +02:00
parent 66a1928a0a
commit 96653be728
5 changed files with 16 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/libcamera/geometry.cpp
View File

@@ -40,12 +40,12 @@ namespace libcamera {
*/
/**
* \var Rectangle::w
* \var Rectangle::width
* \brief The distance between the left and right sides
*/
/**
* \var Rectangle::h
* \var Rectangle::height
* \brief The distance between the top and bottom sides
*/
@@ -57,7 +57,7 @@ const std::string Rectangle::toString() const
{
std::stringstream ss;
ss << "(" << x << "x" << y << ")/" << w << "x" << h;
ss << "(" << x << "x" << y << ")/" << width << "x" << height;
return ss.str();
}
@@ -69,7 +69,7 @@ const std::string Rectangle::toString() const
bool operator==(const Rectangle &lhs, const Rectangle &rhs)
{
return lhs.x == rhs.x && lhs.y == rhs.y &&
lhs.w == rhs.w && lhs.h == rhs.h;
lhs.width == rhs.width && lhs.height == rhs.height;
}
/**