PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

android: CameraDevice: Take shared_ptr in constructor

Browse Source 
CameraDevice takes the ownership of Camera. Therefore,
shared_ptr would rather be used than const shared_ptr&.

Signed-off-by: Hirokazu Honda <hiroh@chromium.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Hirokazu Honda
2021-03-24 16:07:53 +09:00
committed by Laurent Pinchart
parent 1636d4c438
commit 9538ce4cc6
2 changed files with 9 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/android/camera_device.h
View File

@@ -33,7 +33,7 @@ class CameraDevice : protected libcamera::Loggable
{
public:
static std::unique_ptr<CameraDevice> create(unsigned int id,
const std::shared_ptr<libcamera::Camera> &cam);
std::shared_ptr<libcamera::Camera> cam);
~CameraDevice();
int initialize();
@@ -66,7 +66,7 @@ protected:
std::string logPrefix() const override;
private:
CameraDevice(unsigned int id, const std::shared_ptr<libcamera::Camera> &camera);
CameraDevice(unsigned int id, std::shared_ptr<libcamera::Camera> camera);
struct Camera3RequestDescriptor {
Camera3RequestDescriptor(libcamera::Camera *camera,