PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libcamera: pipeline_handler: Remove Camera argument from request handling

Browse Source 
There is no need to pass the Camera pointer to queueRequest(),
completeBuffer() and completeRequest() as the Request also passed
contains the same information. Remove the Camera argument to avoid
situations where the information in the Request and the argument differ.

There is no functional change and no public API change as the interface
is only used between the Camera and PipelineHandler.

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Niklas Söderlund
2020-11-02 23:06:17 +01:00
parent 67bf6bc459
commit 8992b3ffbb
10 changed files with 34 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/libcamera/pipeline/raspberrypi/raspberrypi.cpp
View File

@@ -1507,10 +1507,10 @@ void RPiCameraData::clearIncompleteRequests()
* request? If not, do so now.
*/
if (buffer && buffer->request())
pipe_->completeBuffer(camera_, request, buffer);
pipe_->completeBuffer(request, buffer);
}
pipe_->completeRequest(camera_, request);
pipe_->completeRequest(request);
requestQueue_.pop_front();
}
}
@@ -1534,7 +1534,7 @@ void RPiCameraData::handleStreamBuffer(FrameBuffer *buffer, RPi::Stream *stream)
* Tag the buffer as completed, returning it to the
* application.
*/
pipe_->completeBuffer(camera_, request, buffer);
pipe_->completeBuffer(request, buffer);
} else {
/*
* This buffer was not part of the Request, or there is no
@@ -1597,7 +1597,7 @@ void RPiCameraData::checkRequestCompleted()
if (state_ != State::IpaComplete)
return;
pipe_->completeRequest(camera_, request);
pipe_->completeRequest(request);
requestQueue_.pop_front();
requestCompleted = true;
}