PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

android: camera_metadata: Add setEntry helper

Browse Source 
Add setEntry() helper, that automatically detects if updateEntry() or
addEntry() should be used.

Note that updateEntry() will fail if the entry was not yet added, and
addEntry() will fail is the entry was already added. They are silent
failures that cause unexpected values to find their way into the android
metadata instance.

Previously this helper was not necessary, as (with respect to the
current use case) the preview template generator would always add a key
so the other template generators that used the preview template as
boilerplate could reliably use updateEntry(). The preview template
generator will soon decide based on capabilities whether or not to add
keys, so the other template generators need a helper to decide whether
to use updateEntry() or addEntry().

For now only implement it for enums and arithmetic values, as they will
mainly be used in populating templates.

Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
This commit is contained in:
Paul Elder
2021-11-22 19:09:43 +09:00
parent 733d690b93
commit 86ab84677f
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/android/camera_metadata.h
View File

@@ -33,6 +33,17 @@ public:
bool hasEntry(uint32_t tag) const;
template<typename T,
std::enable_if_t<std::is_arithmetic_v<T> ||
std::is_enum_v<T>> * = nullptr>
bool setEntry(uint32_t tag, const T &data)
{
if (hasEntry(tag))
return updateEntry(tag, &data, 1, sizeof(T));
else
return addEntry(tag, &data, 1, sizeof(T));
}
template<typename T,
std::enable_if_t<std::is_arithmetic_v<T> ||
std::is_enum_v<T>> * = nullptr>