PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libcamera: pipeline: Remove explicit buffer handling

Browse Source 
With the FrameBuffer interface in place there is no need for the Camera
to call into the specific pipelines allocation and freeing of buffers as
it no longer needs to be synchronized with buffer allocation by the
application.

Remove the function prototypes in the pipeline handler base class and
fold the functionality in the pipelines start() and stop() functions
where needed. A follow up patch will remove the now no-op
Camera::allocateBuffers() and Camera::freeBuffers().

Signed-off-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Niklas Söderlund
2019-11-25 13:46:57 +01:00
parent 07156a2713
commit 6cd505ac89
7 changed files with 30 additions and 94 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/libcamera/camera.cpp
View File

@@ -726,12 +726,6 @@ int Camera::allocateBuffers()
return -EINVAL;
}
int ret = pipe_->allocateBuffers(this, activeStreams_);
if (ret) {
LOG(Camera, Error) << "Failed to allocate buffers";
return ret;
}
state_ = CameraPrepared;
return 0;
@@ -752,7 +746,7 @@ int Camera::freeBuffers()
state_ = CameraConfigured;
return pipe_->freeBuffers(this, activeStreams_);
return 0;
}
/**