ipa: mojom: Move CameraSensorInfo struct exclusively to IPA IPC

CameraSensorInfo structure is designed to pass in camera sensor related
information from pipeline-handler to IPA. Since the pipeline-handler
and IPA are connected via mojom IPC IPA interface, the interface
itself provides a more suitable placement of CameraSensorInfo,
instead of camera_sensor.h (which is a libcamera internal header
ultimately, at this point).

As CameraSensorInfo is already defined in core.mojom, it is just
a matter of removing [skipHeader] tag to allow code-generation
of CameraSensorInfo.

Finally, update header paths to include CameraSensorInfo definition
from IPA interfaces instead of "libcamera/internal/camera_sensor.h".

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Signed-off-by: Paul Elder <paul.elder@ideasonboard.com>
Reviewed-by: Jean-Michel Hautbois <jeanmichel.hautbois@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Umang Jain
2021-05-24 14:50:19 +05:30
committed by Laurent Pinchart
parent ff9276cc62
commit 6449590b63
6 changed files with 112 additions and 131 deletions
+1 -16
View File
@@ -14,6 +14,7 @@
#include <libcamera/class.h>
#include <libcamera/controls.h>
#include <libcamera/geometry.h>
#include <libcamera/ipa/core_ipa_interface.h>
#include "libcamera/internal/formats.h"
#include "libcamera/internal/log.h"
@@ -24,22 +25,6 @@ namespace libcamera {
class BayerFormat;
class MediaEntity;
struct CameraSensorInfo {
std::string model;
uint32_t bitsPerPixel;
Size activeAreaSize;
Rectangle analogCrop;
Size outputSize;
uint64_t pixelRate;
uint32_t lineLength;
uint32_t minFrameLength;
uint32_t maxFrameLength;
};
class CameraSensor : protected Loggable
{
public:
+1 -1
View File
@@ -78,7 +78,7 @@ module libcamera;
uint32 height;
};
[skipHeader] struct CameraSensorInfo {
struct CameraSensorInfo {
string model;
uint32 bitsPerPixel;
-2
View File
@@ -18,8 +18,6 @@
#include <libcamera/geometry.h>
#include <libcamera/signal.h>
#include "libcamera/internal/camera_sensor.h"
namespace libcamera {
/*