pipeline: rpi: Don't validate configuration in generateConfiguration()

generateConfiguration() called validate() as a final step, causing the
stride and frameSize fields in StreamConfiguration to be filled in based
on the pixel format and width/height.

If a user application did not clear the stride field when setting up a
custom pixel format and width/height, the pipeline handler would respect
this stride and possibly overallocate buffers with a larger stride than
needed.

Fix this by removing the call to validate() completely, leaving the
stride and frameSize fields defaulting to 0. Removal of this call is
inconsequential as we hard-code a valid configuration for Raspberry Pi
platforms in generateConfiguration().

Bug: https://github.com/raspberrypi/libcamera/issues/138
Bug: https://github.com/raspberrypi/libcamera/issues/141
Signed-off-by: Naushir Patuck <naush@raspberrypi.com>
Reviewed-by: David Plowman <david.plowman@raspberrypi.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>

This commit is contained in:

Naushir Patuck

2024-06-06 12:52:23 +01:00

committed by

Kieran Bingham

parent 20b8538a19

commit 634bc7838f

1 changed files with 0 additions and 2 deletions

									
										src/libcamera/pipeline/rpi/common/pipeline_base.cpp
									
		-2
	
												View File
												
				@@ -496,8 +496,6 @@ PipelineHandlerBase::generateConfiguration(Camera *camera, Span<const StreamRole

						config->addConfiguration(cfg);

					}

					config->validate();

					return config;

				}