PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libcamera: Use const reference for range loops

Browse Source 
Use a const reference in range-based for loops to avoid copies of the
loop elements.

While at it, change looping over controls in
PipelineHandlerUVC::processControls to use structured bindings.

Signed-off-by: Christian Rauch <Rauch.Christian@gmx.de>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
This commit is contained in:
Christian Rauch via libcamera-devel
2022-08-16 20:38:25 +02:00
committed by Jacopo Mondi
parent 868ab2287d
commit 45c198da63
5 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libcamera/device_enumerator.cpp
+1 -1
View File
@@ -161,7 +161,7 @@ std::unique_ptr<DeviceEnumerator> DeviceEnumerator::create()
DeviceEnumerator::~DeviceEnumerator()
{
for (std::shared_ptr<MediaDevice> media : devices_) {
for (const std::shared_ptr<MediaDevice> &media : devices_) {
if (media->busy())
LOG(DeviceEnumerator, Error)
<< "Removing media device " << media->deviceNode()