PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libcamera: ipa: simple: Use symbolic constants for adjust defaults

Browse Source 
The adjust algorithm already uses a symbolic constant for gamma.  Let's
introduce similar constants for contrast and saturation to prevent
copying the numeric defaults to multiple places.

Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Robert Mader <robert.mader@collabora.com>
Signed-off-by: Milan Zamazal <mzamazal@redhat.com>
Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
This commit is contained in:
Milan Zamazal
2026-01-28 12:43:59 +01:00
committed by Kieran Bingham
parent 14d340a27b
commit 43a2ff5c2f
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ipa/simple/algorithms/adjust.cpp
+11 -5
View File
@@ -1,7 +1,7 @@
/* SPDX-License-Identifier: LGPL-2.1-or-later */
/*
* Copyright (C) 2024, Ideas On Board
* Copyright (C) 2024-2025, Red Hat Inc.
* Copyright (C) 2024-2026, Red Hat Inc.
*
* Common image adjustments
*/
@@ -19,14 +19,20 @@ namespace libcamera {
namespace ipa::soft::algorithms {
constexpr float kDefaultContrast = 1.0f;
constexpr float kDefaultSaturation = 1.0f;
LOG_DEFINE_CATEGORY(IPASoftAdjust)
int Adjust::init(IPAContext &context, [[maybe_unused]] const YamlObject &tuningData)
{
context.ctrlMap[&controls::Gamma] = ControlInfo(0.1f, 10.0f, kDefaultGamma);
context.ctrlMap[&controls::Contrast] = ControlInfo(0.0f, 2.0f, 1.0f);
context.ctrlMap[&controls::Gamma] =
ControlInfo(0.1f, 10.0f, kDefaultGamma);
context.ctrlMap[&controls::Contrast] =
ControlInfo(0.0f, 2.0f, kDefaultContrast);
if (context.ccmEnabled)
context.ctrlMap[&controls::Saturation] = ControlInfo(0.0f, 2.0f, 1.0f);
context.ctrlMap[&controls::Saturation] =
ControlInfo(0.0f, 2.0f, kDefaultSaturation);
return 0;
}
@@ -122,7 +128,7 @@ void Adjust::process([[maybe_unused]] IPAContext &context,
metadata.set(controls::Contrast, contrast.value());
const auto &saturation = frameContext.saturation;
metadata.set(controls::Saturation, saturation.value_or(1.0));
metadata.set(controls::Saturation, saturation.value_or(kDefaultSaturation));
}
REGISTER_IPA_ALGORITHM(Adjust, "Adjust")