PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libcamera: rkisp1: Use const reference for sensor configuration

Browse Source 
User-provided sensor configuration is never meant to be altered,
hence pass SensorConfiguration by `const` reference in
RkISP1Path::validate().

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
This commit is contained in:
Umang Jain
2024-10-11 14:52:20 +05:30
parent 302e7e60b1
commit 326e0aa834
2 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/libcamera/pipeline/rkisp1/rkisp1_path.cpp
+1 -1
View File
@@ -253,7 +253,7 @@ RkISP1Path::generateConfiguration(const CameraSensor *sensor, const Size &size,
CameraConfiguration::Status
RkISP1Path::validate(const CameraSensor *sensor,
std::optional<SensorConfiguration> &sensorConfig,
const std::optional<SensorConfiguration> &sensorConfig,
StreamConfiguration *cfg)
{
const std::vector<unsigned int> &mbusCodes = sensor->mbusCodes();
src/libcamera/pipeline/rkisp1/rkisp1_path.h
+1 -1
View File
@@ -45,7 +45,7 @@ public:
const Size &resolution,
StreamRole role);
CameraConfiguration::Status validate(const CameraSensor *sensor,
std::optional<SensorConfiguration> &sensorConfig,
const std::optional<SensorConfiguration> &sensorConfig,
StreamConfiguration *cfg);
int configure(const StreamConfiguration &config,