From 309b99f3ee430e30ebd06ec20ae04a9243512164 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Barnab=C3=A1s=20P=C5=91cze?= Date: Mon, 16 Feb 2026 15:18:06 +0100 Subject: [PATCH] apps: qcam: Fix clang build MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit While gcc ignores attempts to disable unknown warnings, clang does not (`-Wunknown-warning-option`), thus compilation fails due to the recent addition of `-Wno-sfinae-incomplete`. So only add it conditionally. Closes: https://gitlab.freedesktop.org/camera/libcamera/-/issues/315 Fixes: aa2a0812e6692a ("apps: qcam: Disable -Wsfinae-incomplete") Signed-off-by: Barnabás Pőcze Reviewed-by: Kieran Bingham Reviewed-by: Laurent Pinchart --- src/apps/qcam/meson.build | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/apps/qcam/meson.build b/src/apps/qcam/meson.build index 8eb815ee..ef420938 100644 --- a/src/apps/qcam/meson.build +++ b/src/apps/qcam/meson.build @@ -40,7 +40,6 @@ qt6_cpp_args = [ apps_cpp_args, '-DQT_NO_KEYWORDS', '-Wno-extra-semi', - '-Wno-sfinae-incomplete', ] # gcc 12 and 13 output a false positive variable shadowing warning with Qt @@ -50,6 +49,10 @@ if qt6_dep.version().version_compare('>=6.9.0') and \ qt6_cpp_args += ['-Wno-shadow'] endif +if cxx.get_id() == 'gcc' and cxx.version().version_compare('>=16') + qt6_cpp_args += ['-Wno-sfinae-incomplete'] +endif + resources = qt6.preprocess(moc_headers : qcam_moc_headers, qresources : qcam_resources, dependencies : qt6_dep)