libcamera: camera_sensor: Reorder functions
The CameraSensor class has grown a lot since its creation, with many functions added for different types of purposes. They are not grouped by categories in the class definition, generating confusion when reading the header file. Improve readability by sorting functions by category: - Getters for static data (model, entity, focus lens, ...) - Format and sensor configuration accessors - Properties and controls (including test pattern mode) Update the .cpp file accordingly. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com> Reviewed-by: Stefan Klug <stefan.klug@ideasonboard.com>
This commit is contained in:
@@ -46,15 +46,15 @@ public:
|
||||
|
||||
const std::string &model() const { return model_; }
|
||||
const std::string &id() const { return id_; }
|
||||
|
||||
const MediaEntity *entity() const { return entity_; }
|
||||
V4L2Subdevice *device() { return subdev_.get(); }
|
||||
|
||||
CameraLens *focusLens() { return focusLens_.get(); }
|
||||
|
||||
const std::vector<unsigned int> &mbusCodes() const { return mbusCodes_; }
|
||||
std::vector<Size> sizes(unsigned int mbusCode) const;
|
||||
Size resolution() const;
|
||||
const std::vector<controls::draft::TestPatternModeEnum> &testPatternModes() const
|
||||
{
|
||||
return testPatternModes_;
|
||||
}
|
||||
int setTestPatternMode(controls::draft::TestPatternModeEnum mode);
|
||||
|
||||
V4L2SubdeviceFormat getFormat(const std::vector<unsigned int> &mbusCodes,
|
||||
const Size &size) const;
|
||||
@@ -66,18 +66,19 @@ public:
|
||||
Transform transform = Transform::Identity,
|
||||
V4L2SubdeviceFormat *sensorFormat = nullptr);
|
||||
|
||||
const ControlList &properties() const { return properties_; }
|
||||
int sensorInfo(IPACameraSensorInfo *info) const;
|
||||
Transform computeTransform(Orientation *orientation) const;
|
||||
|
||||
const ControlInfoMap &controls() const;
|
||||
ControlList getControls(const std::vector<uint32_t> &ids);
|
||||
int setControls(ControlList *ctrls);
|
||||
|
||||
V4L2Subdevice *device() { return subdev_.get(); }
|
||||
|
||||
const ControlList &properties() const { return properties_; }
|
||||
int sensorInfo(IPACameraSensorInfo *info) const;
|
||||
|
||||
CameraLens *focusLens() { return focusLens_.get(); }
|
||||
|
||||
Transform computeTransform(Orientation *orientation) const;
|
||||
const std::vector<controls::draft::TestPatternModeEnum> &testPatternModes() const
|
||||
{
|
||||
return testPatternModes_;
|
||||
}
|
||||
int setTestPatternMode(controls::draft::TestPatternModeEnum mode);
|
||||
|
||||
protected:
|
||||
std::string logPrefix() const override;
|
||||
@@ -91,8 +92,8 @@ private:
|
||||
void initStaticProperties();
|
||||
void initTestPatternModes();
|
||||
int initProperties();
|
||||
int applyTestPatternMode(controls::draft::TestPatternModeEnum mode);
|
||||
int discoverAncillaryDevices();
|
||||
int applyTestPatternMode(controls::draft::TestPatternModeEnum mode);
|
||||
|
||||
const MediaEntity *entity_;
|
||||
std::unique_ptr<V4L2Subdevice> subdev_;
|
||||
|
||||
Reference in New Issue
Block a user