PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

libcamera: controls: Make ControlValue get/set accessors template methods

Browse Source 
The ControlValue get accessors are implemented with functions of
different names, whlie the set accessors use polymorphism to support
different control types. This isn't very consistent and intuitive. Make
the API clearer by using template methods. This will also have the added
advantage that support for the new types will only require adding
template specialisations, without adding new methods.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
This commit is contained in:
Laurent Pinchart
2019-09-28 00:40:51 +03:00
parent c5dfd9d57e
commit 224ef9776a
7 changed files with 69 additions and 81 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
test/controls/control_value.cpp
View File

@@ -27,12 +27,12 @@ protected:
<< " Bool: " << boolean.toString()
<< endl;
if (integer.getInt() != 1234) {
if (integer.get<int>() != 1234) {
cerr << "Failed to get Integer" << endl;
return TestFail;
}
if (boolean.getBool() != true) {
if (boolean.get<bool>() != true) {
cerr << "Failed to get Boolean" << endl;
return TestFail;
}
@@ -45,19 +45,19 @@ protected:
return TestFail;
}
value.set(true);
value.set<bool>(true);
if (value.isNone()) {
cerr << "Failed to set an empty object" << endl;
return TestFail;
}
if (value.getBool() != true) {
if (value.get<bool>() != true) {
cerr << "Failed to get Booleans" << endl;
return TestFail;
}
value.set(10);
if (value.getInt() != 10) {
value.set<int>(10);
if (value.get<int>() != 10) {
cerr << "Failed to get Integer" << endl;
return TestFail;
}