PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

py: Fix include order

Browse Source 
Python.h hence the pybind header must be included first since pyconfig.h
unconditionally overrides certain feature test macros[0]. This was mostly
hidden by the fact that macro redefinitions with the same value do not
trigger compiler warnings. However, glibc 43 has changed certain defaults[1],
causing mismatches, leading to compiler warnings.

So change the include order so that `<pybind11/...>` headers are included
first and then the local `"py_..."` headers, and then everything else. Also
remove some redundant includes.

Adjust `.clang-format` and the documentation as well.

[0]: https://docs.python.org/3/c-api/intro.html#include-files
[1]: https://sourceware.org/git/?p=glibc.git;a=commit;h=a5cc3018f31a125f019685b239c6e5a0bf1a272b

Link: https://github.com/python/cpython/issues/61322
Signed-off-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
This commit is contained in:
Barnabás Pőcze
2026-03-06 18:24:56 +01:00
parent 14ba4d1680
commit 20ea9ae1e5
14 changed files with 44 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Documentation/coding-style.rst
+6
View File
@@ -95,6 +95,12 @@ System and library headers shall be included with angle brackets. Project
headers shall be included with angle brackets for the libcamera public API
headers, and with double quotes for internal libcamera headers.
.. note::
As an exception pybind11 headers and local ``py_*`` headers must be included first
in the Python bindings due to the requirements outlined in the `Python documentation`_.
.. _Python documentation: https://docs.python.org/3/c-api/intro.html#include-files
C++ Specific Rules
------------------