libcamera: Drop argument from LIBCAMERA_DECLARE_PRIVATE

The LIBCAMERA_DECLARE_PRIVATE() macro, used by the library classes
that inherit from libcamera::Extensible in order to implement the
PIMPL pattern, expands to:

public:									\
	class Private;							\
	friend class Private;

The 'klass' argument is not used and it might confuse developers as
it might hint that the class that defines the pattern's implementation
can be freely named, while it is actually hardcoded to 'Private'.

Drop the argument from the macro definition.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Hanlin Chen <hanlinchen@google.com>
Signed-off-by: Jacopo Mondi <jacopo@jmondi.org>
This commit is contained in:
Jacopo Mondi
2021-04-18 16:42:17 +02:00
parent d40430116b
commit 1fca6228fe
5 changed files with 6 additions and 8 deletions
+2 -2
View File
@@ -30,7 +30,7 @@ namespace libcamera {
#endif
#ifndef __DOXYGEN__
#define LIBCAMERA_DECLARE_PRIVATE(klass) \
#define LIBCAMERA_DECLARE_PRIVATE() \
public: \
class Private; \
friend class Private;
@@ -46,7 +46,7 @@ public: \
_o<Public>();
#else
#define LIBCAMERA_DECLARE_PRIVATE(klass)
#define LIBCAMERA_DECLARE_PRIVATE()
#define LIBCAMERA_DECLARE_PUBLIC(klass)
#define LIBCAMERA_D_PTR(klass)
#define LIBCAMERA_O_PTR(klass)