controls: Add boolean constructors for ControlInfo
It would be convenient to be able to iterate over available boolean values, for example for controls that designate if some function can be enabled/disabled. The current min/max/def constructor is insufficient, as .values() is empty, so the values cannot be easily iterated over, and creating a Span of booleans does not work for the values constructor. Add new constructors to ControlInfo that takes a set of booleans (if both booleans are valid values) plus a default, and another that takes only one boolean (if only one boolean is a valid value). Update the ControlInfo test accordingly. Signed-off-by: Paul Elder <paul.elder@ideasonboard.com> Reviewed-by: Jacopo Mondi <jacopo@jmondi.org>
This commit is contained in:
@@ -44,6 +44,39 @@ protected:
|
||||
return TestFail;
|
||||
}
|
||||
|
||||
/*
|
||||
* Test information retrieval from a control with boolean
|
||||
* values.
|
||||
*/
|
||||
ControlInfo aeEnable({ false, true }, false);
|
||||
|
||||
if (aeEnable.min().get<bool>() != false ||
|
||||
aeEnable.def().get<bool>() != false ||
|
||||
aeEnable.max().get<bool>() != true) {
|
||||
cout << "Invalid control range for AeEnable" << endl;
|
||||
return TestFail;
|
||||
}
|
||||
|
||||
if (aeEnable.values()[0].get<bool>() != false ||
|
||||
aeEnable.values()[1].get<bool>() != true) {
|
||||
cout << "Invalid control values for AeEnable" << endl;
|
||||
return TestFail;
|
||||
}
|
||||
|
||||
ControlInfo awbEnable(true);
|
||||
|
||||
if (awbEnable.min().get<bool>() != true ||
|
||||
awbEnable.def().get<bool>() != true ||
|
||||
awbEnable.max().get<bool>() != true) {
|
||||
cout << "Invalid control range for AwbEnable" << endl;
|
||||
return TestFail;
|
||||
}
|
||||
|
||||
if (awbEnable.values()[0].get<bool>() != true) {
|
||||
cout << "Invalid control values for AwbEnable" << endl;
|
||||
return TestFail;
|
||||
}
|
||||
|
||||
return TestPass;
|
||||
}
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user