From 0a9cf7e0eb6aafcfaeda4c5774fb04db9186430d Mon Sep 17 00:00:00 2001 From: Milan Zamazal Date: Thu, 4 Dec 2025 17:46:34 +0100 Subject: [PATCH] libcamera: simple: Move colour space logging after adjustment MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The log message about adjusting an unspecified colour space should log the value after, not before, the adjustment. Fixes: 5a33bc10e9d3bc ("libcamera: software_isp: Assign colour spaces in configurations") Reviewed-by: Barnabás Pőcze Reviewed-by: Umang Jain Signed-off-by: Milan Zamazal Signed-off-by: Kieran Bingham --- src/libcamera/pipeline/simple/simple.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/libcamera/pipeline/simple/simple.cpp b/src/libcamera/pipeline/simple/simple.cpp index a06a5292..ebbb04fb 100644 --- a/src/libcamera/pipeline/simple/simple.cpp +++ b/src/libcamera/pipeline/simple/simple.cpp @@ -1249,9 +1249,6 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate() default: cfg.colorSpace = ColorSpace::Raw; } - LOG(SimplePipeline, Debug) - << "Unspecified color space set to " - << cfg.colorSpace.value().toString(); /* * Adjust the assigned color space to make sure everything is OK. * Since this is assigning an unspecified color space rather than @@ -1259,6 +1256,9 @@ CameraConfiguration::Status SimpleCameraConfiguration::validate() * to Adjusted. */ cfg.colorSpace->adjust(pixelFormat); + LOG(SimplePipeline, Debug) + << "Unspecified color space set to " + << cfg.colorSpace.value().toString(); } else { if (cfg.colorSpace->adjust(pixelFormat)) { LOG(SimplePipeline, Debug)