From 098fc4eeed6b0fcb32c297d97a500557edf98c06 Mon Sep 17 00:00:00 2001
From: Stefan Klug <stefan.klug@ideasonboard.com>
Date: Wed, 28 Jan 2026 17:00:25 +0100
Subject: [PATCH] ipa: rkisp1: lsc: Move local types into anonymous namespace
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Move all local helpers into an anonymous namespace and drop a static
modifier that is no longer needed.

Signed-off-by: Stefan Klug <stefan.klug@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com>
Reviewed-by: Barnabás Pőcze <barnabas.pocze@ideasonboard.com>
---
 src/ipa/rkisp1/algorithms/lsc.cpp | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/src/ipa/rkisp1/algorithms/lsc.cpp b/src/ipa/rkisp1/algorithms/lsc.cpp
index a5c15ea3..99e1e05f 100644
--- a/src/ipa/rkisp1/algorithms/lsc.cpp
+++ b/src/ipa/rkisp1/algorithms/lsc.cpp
@@ -27,8 +27,6 @@ namespace libcamera {
 
 namespace ipa {
 
-constexpr int kColourTemperatureChangeThreshhold = 10;
-
 template<typename T>
 void interpolateVector(const std::vector<T> &a, const std::vector<T> &b,
 		       std::vector<T> &dest, double lambda)
@@ -70,6 +68,10 @@ namespace ipa::rkisp1::algorithms {
 
 LOG_DEFINE_CATEGORY(RkISP1Lsc)
 
+namespace {
+
+constexpr int kColourTemperatureChangeThreshhold = 10;
+
 class LscPolynomialLoader
 {
 public:
@@ -276,8 +278,8 @@ std::vector<uint16_t> LscTableLoader::parseTable(const YamlObject &tuningData,
 	return table;
 }
 
-static std::vector<double> parseSizes(const YamlObject &tuningData,
-				      const char *prop)
+std::vector<double> parseSizes(const YamlObject &tuningData,
+			       const char *prop)
 {
 	std::vector<double> sizes =
 		tuningData[prop].getList<double>().value_or(std::vector<double>{});
@@ -306,6 +308,8 @@ static std::vector<double> parseSizes(const YamlObject &tuningData,
 	return sizes;
 }
 
+} /* namespace */
+
 LensShadingCorrection::LensShadingCorrection()
 	: lastAppliedCt_(0), lastAppliedQuantizedCt_(0)
 {