android: post_processor: Drop return value for process()
PostProcessor::process() is invoked by CameraStream class in case any post-processing is required for the camera stream. The failure or success is checked via the value returned by CameraStream::process(). Now that the post-processor notifies about the post-processing completion operation, we can drop the return value of PostProcessor::process(). The status of post-processing is passed to CameraDevice::streamProcessingComplete() by the PostProcessor::processComplete signal's slot. Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
This commit is contained in:
@@ -98,7 +98,7 @@ void PostProcessorJpeg::generateThumbnail(const FrameBuffer &source,
|
||||
}
|
||||
}
|
||||
|
||||
int PostProcessorJpeg::process(Camera3RequestDescriptor::StreamBuffer *streamBuffer)
|
||||
void PostProcessorJpeg::process(Camera3RequestDescriptor::StreamBuffer *streamBuffer)
|
||||
{
|
||||
ASSERT(encoder_);
|
||||
|
||||
@@ -199,7 +199,7 @@ int PostProcessorJpeg::process(Camera3RequestDescriptor::StreamBuffer *streamBuf
|
||||
if (jpeg_size < 0) {
|
||||
LOG(JPEG, Error) << "Failed to encode stream image";
|
||||
processComplete.emit(streamBuffer, PostProcessor::Status::Error);
|
||||
return jpeg_size;
|
||||
return;
|
||||
}
|
||||
|
||||
/* Fill in the JPEG blob header. */
|
||||
@@ -213,6 +213,4 @@ int PostProcessorJpeg::process(Camera3RequestDescriptor::StreamBuffer *streamBuf
|
||||
/* Update the JPEG result Metadata. */
|
||||
resultMetadata->addEntry(ANDROID_JPEG_SIZE, jpeg_size);
|
||||
processComplete.emit(streamBuffer, PostProcessor::Status::Success);
|
||||
|
||||
return 0;
|
||||
}
|
||||
|
||||
@@ -22,7 +22,7 @@ public:
|
||||
|
||||
int configure(const libcamera::StreamConfiguration &incfg,
|
||||
const libcamera::StreamConfiguration &outcfg) override;
|
||||
int process(Camera3RequestDescriptor::StreamBuffer *streamBuffer) override;
|
||||
void process(Camera3RequestDescriptor::StreamBuffer *streamBuffer) override;
|
||||
|
||||
private:
|
||||
void generateThumbnail(const libcamera::FrameBuffer &source,
|
||||
|
||||
Reference in New Issue
Block a user