PawletOS/external_libcamera
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

ipa: rkisp1: awb: Use RGB class to store colour gains

Browse Source 
Replace the manual storage of gains in the IPA active state and frame
context with usage of the RGB class. This simplifies the code thanks to
usage of the arithmetic functions provided by the RGB class.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Milan Zamazal <mzamazal@redhat.com>
This commit is contained in:
Laurent Pinchart
2024-11-18 21:11:08 +02:00
parent 16c15c428d
commit 01919308e9
3 changed files with 32 additions and 90 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ipa/rkisp1/ipa_context.cpp
+2 -29
View File
@@ -188,30 +188,12 @@ namespace libcamera::ipa::rkisp1 {
* \struct IPAActiveState::awb.gains
* \brief White balance gains
*
* \struct IPAActiveState::awb.gains.manual
* \var IPAActiveState::awb.gains.manual
* \brief Manual white balance gains (set through requests)
*
* \var IPAActiveState::awb.gains.manual.red
* \brief Manual white balance gain for R channel
*
* \var IPAActiveState::awb.gains.manual.green
* \brief Manual white balance gain for G channel
*
* \var IPAActiveState::awb.gains.manual.blue
* \brief Manual white balance gain for B channel
*
* \struct IPAActiveState::awb.gains.automatic
* \var IPAActiveState::awb.gains.automatic
* \brief Automatic white balance gains (computed by the algorithm)
*
* \var IPAActiveState::awb.gains.automatic.red
* \brief Automatic white balance gain for R channel
*
* \var IPAActiveState::awb.gains.automatic.green
* \brief Automatic white balance gain for G channel
*
* \var IPAActiveState::awb.gains.automatic.blue
* \brief Automatic white balance gain for B channel
*
* \var IPAActiveState::awb.temperatureK
* \brief Estimated color temperature
*
@@ -333,15 +315,6 @@ namespace libcamera::ipa::rkisp1 {
* \struct IPAFrameContext::awb.gains
* \brief White balance gains
*
* \var IPAFrameContext::awb.gains.red
* \brief White balance gain for R channel
*
* \var IPAFrameContext::awb.gains.green
* \brief White balance gain for G channel
*
* \var IPAFrameContext::awb.gains.blue
* \brief White balance gain for B channel
*
* \var IPAFrameContext::awb.temperatureK
* \brief Estimated color temperature
*