74 lines
4.2 KiB
Diff
74 lines
4.2 KiB
Diff
From: uazo <uazo@users.noreply.github.com>
|
|
Date: Wed, 30 Sep 2020 07:40:01 +0000
|
|
Subject: Restore chrome password store
|
|
|
|
License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html
|
|
---
|
|
chrome/browser/resources/password_manager/user_utils_mixin.ts | 4 ++--
|
|
chrome/browser/ui/android/strings/android_chrome_strings.grd | 2 +-
|
|
components/password_manager/core/browser/buildflags.gni | 2 +-
|
|
components/sync/base/features.cc | 1 +
|
|
.../password_features_cc/Restore-chrome-password-store.inc | 1 +
|
|
5 files changed, 6 insertions(+), 4 deletions(-)
|
|
create mode 100644 cromite_flags/components/password_manager/core/browser/features/password_features_cc/Restore-chrome-password-store.inc
|
|
|
|
diff --git a/chrome/browser/resources/password_manager/user_utils_mixin.ts b/chrome/browser/resources/password_manager/user_utils_mixin.ts
|
|
--- a/chrome/browser/resources/password_manager/user_utils_mixin.ts
|
|
+++ b/chrome/browser/resources/password_manager/user_utils_mixin.ts
|
|
@@ -129,11 +129,11 @@ export const UserUtilMixin = dedupingMixin(
|
|
}
|
|
|
|
private computeIsEligibleForAccountStorage_(): boolean {
|
|
- return !!this.syncInfo_ && this.syncInfo_.isEligibleForAccountStorage;
|
|
+ return !!this.syncInfo_ && !!this.syncInfo_.isEligibleForAccountStorage;
|
|
}
|
|
|
|
private computeIsSyncingPasswords_(): boolean {
|
|
- return !!this.syncInfo_ && this.syncInfo_.isSyncingPasswords;
|
|
+ return !!this.syncInfo_ && !!this.syncInfo_.isSyncingPasswords;
|
|
}
|
|
|
|
private computeAccountEmail_(): string {
|
|
diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
|
--- a/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
|
+++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd
|
|
@@ -714,7 +714,7 @@ For more settings that use data to improve your Chrome experience, go to <ph nam
|
|
Passwords
|
|
</message>
|
|
<message name="IDS_PASSWORD_MANAGER_SETTINGS_TITLE" desc="Title for the settings menu item leading to the Password Manager UI surface. This allows users to e.g. manage their saved passwords, toggle saving and auto-sign-in on/off, etc. [CHAR_LIMIT=32]">
|
|
- Google Password Manager
|
|
+ Password Manager
|
|
</message>
|
|
<message name="IDS_PASSWORD_SAVING_ON_BY_ADMINISTRATOR" desc="Subtitle for the settings menu item leading to the Password Manager UI surface, shown when the device administrator set saving passwords to enabled.">
|
|
Password saving is turned on by your administrator
|
|
diff --git a/components/password_manager/core/browser/buildflags.gni b/components/password_manager/core/browser/buildflags.gni
|
|
--- a/components/password_manager/core/browser/buildflags.gni
|
|
+++ b/components/password_manager/core/browser/buildflags.gni
|
|
@@ -9,7 +9,7 @@ declare_args() {
|
|
# The legacy password store backend is supported on android but usually disabled
|
|
# in favor of a downstream implementation. Important: the support for this flag
|
|
# is planned to be removed in November 2024.
|
|
- use_login_database_as_backend = !is_android
|
|
+ use_login_database_as_backend = true
|
|
}
|
|
|
|
# Drawables from the downstream clank/ repository are
|
|
diff --git a/components/sync/base/features.cc b/components/sync/base/features.cc
|
|
--- a/components/sync/base/features.cc
|
|
+++ b/components/sync/base/features.cc
|
|
@@ -91,6 +91,7 @@ BASE_FEATURE(kEnablePasswordsAccountStorageForNonSyncingUsers,
|
|
base::FEATURE_ENABLED_BY_DEFAULT
|
|
#endif
|
|
);
|
|
+SET_CROMITE_FEATURE_DISABLED(kEnablePasswordsAccountStorageForNonSyncingUsers);
|
|
|
|
BASE_FEATURE(kSyncEnableContactInfoDataTypeForDasherUsers,
|
|
"SyncEnableContactInfoDataTypeForDasherUsers",
|
|
diff --git a/cromite_flags/components/password_manager/core/browser/features/password_features_cc/Restore-chrome-password-store.inc b/cromite_flags/components/password_manager/core/browser/features/password_features_cc/Restore-chrome-password-store.inc
|
|
new file mode 100644
|
|
--- /dev/null
|
|
+++ b/cromite_flags/components/password_manager/core/browser/features/password_features_cc/Restore-chrome-password-store.inc
|
|
@@ -0,0 +1 @@
|
|
+SET_CROMITE_FEATURE_ENABLED(kSkipUndecryptablePasswords);
|
|
--
|