117 lines
7.8 KiB
Diff
117 lines
7.8 KiB
Diff
From: csagan5 <32685696+csagan5@users.noreply.github.com>
|
|
Date: Thu, 27 Feb 2020 23:23:59 +0100
|
|
Subject: Do not compile QR code sharing
|
|
|
|
---
|
|
chrome/android/java/AndroidManifest.xml | 16 ------------
|
|
.../ChromeProvidedSharingOptionsProvider.java | 25 -------------------
|
|
chrome/browser/share/android/java_sources.gni | 18 -------------
|
|
3 files changed, 59 deletions(-)
|
|
|
|
diff --git a/chrome/android/java/AndroidManifest.xml b/chrome/android/java/AndroidManifest.xml
|
|
--- a/chrome/android/java/AndroidManifest.xml
|
|
+++ b/chrome/android/java/AndroidManifest.xml
|
|
@@ -729,22 +729,6 @@ by a child template that "extends" this file.
|
|
</intent-filter>
|
|
</activity>
|
|
|
|
- <activity
|
|
- android:name="org.chromium.chrome.browser.share.qrcode.QrCodeShareActivity"
|
|
- android:icon="@drawable/ic_launcher"
|
|
- android:label="@string/qr_code_share_icon_label"
|
|
- android:enabled="false"
|
|
- android:excludeFromRecents="true"
|
|
- android:exported="true"
|
|
- android:noHistory="true"
|
|
- android:theme="@android:style/Theme.NoDisplay"
|
|
- android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc|screenLayout|smallestScreenSize" >
|
|
- <intent-filter>
|
|
- <action android:name="android.intent.action.SEND" />
|
|
- <category android:name="android.intent.category.DEFAULT" />
|
|
- <data android:mimeType="text/plain" />
|
|
- </intent-filter>
|
|
- </activity>
|
|
|
|
<activity
|
|
android:name="org.chromium.chrome.browser.vr.VrCancelAnimationActivity"
|
|
diff --git a/chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/share_sheet/ChromeProvidedSharingOptionsProvider.java b/chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/share_sheet/ChromeProvidedSharingOptionsProvider.java
|
|
--- a/chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/share_sheet/ChromeProvidedSharingOptionsProvider.java
|
|
+++ b/chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/share_sheet/ChromeProvidedSharingOptionsProvider.java
|
|
@@ -22,7 +22,6 @@ import org.chromium.chrome.browser.preferences.Pref;
|
|
import org.chromium.chrome.browser.preferences.PrefServiceBridge;
|
|
import org.chromium.chrome.browser.send_tab_to_self.SendTabToSelfShareActivity;
|
|
import org.chromium.chrome.browser.share.ChromeShareExtras;
|
|
-import org.chromium.chrome.browser.share.qrcode.QrCodeCoordinator;
|
|
import org.chromium.chrome.browser.share.screenshot.ScreenshotCoordinator;
|
|
import org.chromium.chrome.browser.share.share_sheet.ShareSheetPropertyModelBuilder.ContentType;
|
|
import org.chromium.chrome.browser.tab.Tab;
|
|
@@ -145,10 +144,6 @@ class ChromeProvidedSharingOptionsProvider {
|
|
mOrderedFirstPartyOptions.add(createCopyTextFirstPartyOption());
|
|
}
|
|
mOrderedFirstPartyOptions.add(createSendTabToSelfFirstPartyOption());
|
|
- if (ChromeFeatureList.isEnabled(ChromeFeatureList.CHROME_SHARE_QRCODE)
|
|
- && !mTabProvider.get().getWebContents().isIncognito()) {
|
|
- mOrderedFirstPartyOptions.add(createQrCodeFirstPartyOption());
|
|
- }
|
|
if (mPrefServiceBridge.getBoolean(Pref.PRINTING_ENABLED)) {
|
|
mOrderedFirstPartyOptions.add(createPrintingFirstPartyOption());
|
|
}
|
|
@@ -261,26 +256,6 @@ class ChromeProvidedSharingOptionsProvider {
|
|
ContentType.IMAGE));
|
|
}
|
|
|
|
- private FirstPartyOption createQrCodeFirstPartyOption() {
|
|
- PropertyModel propertyModel = ShareSheetPropertyModelBuilder.createPropertyModel(
|
|
- AppCompatResources.getDrawable(mActivity, R.drawable.qr_code),
|
|
- mActivity.getResources().getString(R.string.qr_code_share_icon_label),
|
|
- (currentActivity)
|
|
- -> {
|
|
- RecordUserAction.record("SharingHubAndroid.QRCodeSelected");
|
|
- RecordHistogram.recordMediumTimesHistogram(
|
|
- "Sharing.SharingHubAndroid.TimeToShare",
|
|
- System.currentTimeMillis() - mShareStartTime);
|
|
- mBottomSheetController.hideContent(mBottomSheetContent, true);
|
|
- QrCodeCoordinator qrCodeCoordinator = new QrCodeCoordinator(mActivity, mUrl);
|
|
- qrCodeCoordinator.show();
|
|
- },
|
|
- /*isFirstParty=*/true);
|
|
- return new FirstPartyOption(propertyModel,
|
|
- Arrays.asList(ContentType.LINK_PAGE_VISIBLE, ContentType.LINK_PAGE_NOT_VISIBLE,
|
|
- ContentType.IMAGE));
|
|
- }
|
|
-
|
|
private FirstPartyOption createPrintingFirstPartyOption() {
|
|
PropertyModel propertyModel = ShareSheetPropertyModelBuilder.createPropertyModel(
|
|
AppCompatResources.getDrawable(mActivity, R.drawable.sharing_print),
|
|
diff --git a/chrome/browser/share/android/java_sources.gni b/chrome/browser/share/android/java_sources.gni
|
|
--- a/chrome/browser/share/android/java_sources.gni
|
|
+++ b/chrome/browser/share/android/java_sources.gni
|
|
@@ -8,24 +8,6 @@ share_java_sources = [
|
|
"//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/BitmapDownloadRequest.java",
|
|
"//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/BitmapUriRequest.java",
|
|
"//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/clipboard/ClipboardImageFileProvider.java",
|
|
- "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/QRCodeGenerationRequest.java",
|
|
- "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/QrCodeCoordinator.java",
|
|
- "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/QrCodeDialog.java",
|
|
- "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/QrCodeDialogTab.java",
|
|
- "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/QrCodePageAdapter.java",
|
|
- "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/TabLayoutPageListener.java",
|
|
- "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/scan_tab/CameraPreview.java",
|
|
- "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/scan_tab/CameraPreviewOverlay.java",
|
|
- "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/scan_tab/QrCodeScanCoordinator.java",
|
|
- "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/scan_tab/QrCodeScanMediator.java",
|
|
- "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/scan_tab/QrCodeScanView.java",
|
|
- "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/scan_tab/QrCodeScanViewBinder.java",
|
|
- "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/scan_tab/QrCodeScanViewProperties.java",
|
|
- "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/share_tab/QrCodeShareCoordinator.java",
|
|
- "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/share_tab/QrCodeShareMediator.java",
|
|
- "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/share_tab/QrCodeShareView.java",
|
|
- "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/share_tab/QrCodeShareViewBinder.java",
|
|
- "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/share_tab/QrCodeShareViewProperties.java",
|
|
"//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/screenshot/ScreenshotCoordinator.java",
|
|
"//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/screenshot/ScreenshotShareSheetCoordinator.java",
|
|
"//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/screenshot/ScreenshotShareSheetDialog.java",
|
|
--
|
|
2.17.1
|
|
|