88 lines
3.2 KiB
Diff
88 lines
3.2 KiB
Diff
From: csagan5 <32685696+csagan5@users.noreply.github.com>
|
|
Date: Wed, 20 Feb 2019 21:41:26 +0100
|
|
Subject: Disable metrics collection for NTP tiles
|
|
|
|
---
|
|
.../browser/android/ntp/most_visited_sites_bridge.cc | 10 ++--------
|
|
components/ntp_tiles/BUILD.gn | 3 ---
|
|
2 files changed, 2 insertions(+), 11 deletions(-)
|
|
|
|
diff --git a/chrome/browser/android/ntp/most_visited_sites_bridge.cc b/chrome/browser/android/ntp/most_visited_sites_bridge.cc
|
|
--- a/chrome/browser/android/ntp/most_visited_sites_bridge.cc
|
|
+++ b/chrome/browser/android/ntp/most_visited_sites_bridge.cc
|
|
@@ -25,7 +25,6 @@
|
|
#include "chrome/browser/profiles/profile_android.h"
|
|
#include "components/favicon_base/favicon_types.h"
|
|
#include "components/history/core/browser/history_service.h"
|
|
-#include "components/ntp_tiles/metrics.h"
|
|
#include "components/ntp_tiles/most_visited_sites.h"
|
|
#include "components/ntp_tiles/section_type.h"
|
|
#include "ui/gfx/android/java_bitmap.h"
|
|
@@ -45,7 +44,6 @@ using ntp_tiles::NTPTilesVector;
|
|
using ntp_tiles::SectionType;
|
|
using ntp_tiles::TileTitleSource;
|
|
using ntp_tiles::TileSource;
|
|
-using ntp_tiles::TileVisualType;
|
|
|
|
namespace {
|
|
|
|
@@ -233,7 +231,6 @@ void MostVisitedSitesBridge::RecordPageImpression(
|
|
JNIEnv* env,
|
|
const JavaParamRef<jobject>& obj,
|
|
jint jtiles_count) {
|
|
- ntp_tiles::metrics::RecordPageImpression(jtiles_count);
|
|
}
|
|
|
|
void MostVisitedSitesBridge::RecordTileImpression(
|
|
@@ -245,6 +242,7 @@ void MostVisitedSitesBridge::RecordTileImpression(
|
|
jint jtitle_source,
|
|
jint jsource,
|
|
const JavaParamRef<jobject>& jurl) {
|
|
+#if 0
|
|
std::unique_ptr<GURL> url = url::GURLAndroid::ToNativeGURL(env, jurl);
|
|
TileTitleSource title_source = static_cast<TileTitleSource>(jtitle_source);
|
|
TileSource source = static_cast<TileSource>(jsource);
|
|
@@ -254,6 +252,7 @@ void MostVisitedSitesBridge::RecordTileImpression(
|
|
|
|
ntp_tiles::metrics::RecordTileImpression(ntp_tiles::NTPTileImpression(
|
|
jindex, source, title_source, visual_type, icon_type, *url));
|
|
+#endif
|
|
}
|
|
|
|
void MostVisitedSitesBridge::RecordOpenedMostVisitedItem(
|
|
@@ -263,11 +262,6 @@ void MostVisitedSitesBridge::RecordOpenedMostVisitedItem(
|
|
jint tile_type,
|
|
jint title_source,
|
|
jint source) {
|
|
- ntp_tiles::metrics::RecordTileClick(ntp_tiles::NTPTileImpression(
|
|
- index, static_cast<TileSource>(source),
|
|
- static_cast<TileTitleSource>(title_source),
|
|
- static_cast<TileVisualType>(tile_type), favicon_base::IconType::kInvalid,
|
|
- /*url_for_rappor=*/GURL()));
|
|
}
|
|
|
|
static jlong JNI_MostVisitedSitesBridge_Init(
|
|
diff --git a/components/ntp_tiles/BUILD.gn b/components/ntp_tiles/BUILD.gn
|
|
--- a/components/ntp_tiles/BUILD.gn
|
|
+++ b/components/ntp_tiles/BUILD.gn
|
|
@@ -20,8 +20,6 @@ static_library("ntp_tiles") {
|
|
"icon_cacher.h",
|
|
"icon_cacher_impl.cc",
|
|
"icon_cacher_impl.h",
|
|
- "metrics.cc",
|
|
- "metrics.h",
|
|
"most_visited_sites.cc",
|
|
"most_visited_sites.h",
|
|
"ntp_tile.cc",
|
|
@@ -83,7 +81,6 @@ source_set("unit_tests") {
|
|
"custom_links_manager_impl_unittest.cc",
|
|
"custom_links_store_unittest.cc",
|
|
"icon_cacher_impl_unittest.cc",
|
|
- "metrics_unittest.cc",
|
|
"most_visited_sites_unittest.cc",
|
|
"popular_sites_impl_unittest.cc",
|
|
]
|
|
--
|
|
2.17.1
|
|
|