97 lines
6.3 KiB
Diff
97 lines
6.3 KiB
Diff
From: csagan5 <32685696+csagan5@users.noreply.github.com>
|
|
Date: Wed, 27 Jun 2018 11:02:38 +0200
|
|
Subject: Always use new tab page for default home page
|
|
|
|
Ignore any partner-provided home page.
|
|
|
|
License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html
|
|
---
|
|
.../org/chromium/chrome/browser/homepage/HomepageManager.java | 4 ----
|
|
.../chrome/browser/new_tab_url/DseNewTabUrlManager.java | 2 +-
|
|
.../partnerbookmarks/PartnerBookmarksProviderIterator.java | 1 +
|
|
.../partnercustomizations/PartnerBrowserCustomizations.java | 2 +-
|
|
.../org/chromium/components/search_engines/TemplateUrl.java | 1 +
|
|
.../search_engines/android/template_url_service_android.cc | 1 +
|
|
.../always-use-new-tab-page-for-default-home-page.inc | 1 +
|
|
7 files changed, 6 insertions(+), 6 deletions(-)
|
|
create mode 100755 cromite_flags/chrome/browser/flags/android/chrome_feature_list_cc/always-use-new-tab-page-for-default-home-page.inc
|
|
|
|
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/homepage/HomepageManager.java b/chrome/android/java/src/org/chromium/chrome/browser/homepage/HomepageManager.java
|
|
--- a/chrome/android/java/src/org/chromium/chrome/browser/homepage/HomepageManager.java
|
|
+++ b/chrome/android/java/src/org/chromium/chrome/browser/homepage/HomepageManager.java
|
|
@@ -164,10 +164,6 @@ public class HomepageManager
|
|
* tab page if the homepage button is force enabled via flag.
|
|
*/
|
|
public GURL getDefaultHomepageGurl(boolean isIncognito) {
|
|
- if (PartnerBrowserCustomizations.getInstance().isHomepageProviderAvailableAndEnabled()) {
|
|
- return assumeNonNull(PartnerBrowserCustomizations.getInstance().getHomePageUrl());
|
|
- }
|
|
-
|
|
String homepagePartnerDefaultGurlSerialized =
|
|
ChromeSharedPreferences.getInstance()
|
|
.readString(
|
|
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/new_tab_url/DseNewTabUrlManager.java b/chrome/android/java/src/org/chromium/chrome/browser/new_tab_url/DseNewTabUrlManager.java
|
|
--- a/chrome/android/java/src/org/chromium/chrome/browser/new_tab_url/DseNewTabUrlManager.java
|
|
+++ b/chrome/android/java/src/org/chromium/chrome/browser/new_tab_url/DseNewTabUrlManager.java
|
|
@@ -59,7 +59,7 @@ public class DseNewTabUrlManager {
|
|
|
|
/** Returns whether the feature NewTabSearchEngineUrlAndroid is enabled. */
|
|
public static boolean isNewTabSearchEngineUrlAndroidEnabled() {
|
|
- return true;
|
|
+ return false;
|
|
}
|
|
|
|
/**
|
|
diff --git a/chrome/browser/partnerbookmarks/android/java/src/org/chromium/chrome/browser/partnerbookmarks/PartnerBookmarksProviderIterator.java b/chrome/browser/partnerbookmarks/android/java/src/org/chromium/chrome/browser/partnerbookmarks/PartnerBookmarksProviderIterator.java
|
|
--- a/chrome/browser/partnerbookmarks/android/java/src/org/chromium/chrome/browser/partnerbookmarks/PartnerBookmarksProviderIterator.java
|
|
+++ b/chrome/browser/partnerbookmarks/android/java/src/org/chromium/chrome/browser/partnerbookmarks/PartnerBookmarksProviderIterator.java
|
|
@@ -70,6 +70,7 @@ public class PartnerBookmarksProviderIterator implements PartnerBookmark.Bookmar
|
|
new AsyncTask<@Nullable Cursor>() {
|
|
@Override
|
|
protected @Nullable Cursor doInBackground() {
|
|
+ if ((true)) return null;
|
|
try {
|
|
return ContextUtils.getApplicationContext()
|
|
.getContentResolver()
|
|
diff --git a/chrome/browser/partnercustomizations/java/src/org/chromium/chrome/browser/partnercustomizations/PartnerBrowserCustomizations.java b/chrome/browser/partnercustomizations/java/src/org/chromium/chrome/browser/partnercustomizations/PartnerBrowserCustomizations.java
|
|
--- a/chrome/browser/partnercustomizations/java/src/org/chromium/chrome/browser/partnercustomizations/PartnerBrowserCustomizations.java
|
|
+++ b/chrome/browser/partnercustomizations/java/src/org/chromium/chrome/browser/partnercustomizations/PartnerBrowserCustomizations.java
|
|
@@ -213,7 +213,7 @@ public class PartnerBrowserCustomizations {
|
|
& ApplicationInfo.FLAG_SYSTEM)
|
|
== 1
|
|
|| !VersionInfo.isStableBuild();
|
|
- if (!systemOrPreStable) {
|
|
+ if ((true)) {
|
|
// Only allow partner customization if this browser is a system
|
|
// package, or is in pre-stable channels.
|
|
return null;
|
|
diff --git a/components/search_engines/android/java/src/org/chromium/components/search_engines/TemplateUrl.java b/components/search_engines/android/java/src/org/chromium/components/search_engines/TemplateUrl.java
|
|
--- a/components/search_engines/android/java/src/org/chromium/components/search_engines/TemplateUrl.java
|
|
+++ b/components/search_engines/android/java/src/org/chromium/components/search_engines/TemplateUrl.java
|
|
@@ -110,6 +110,7 @@ public class TemplateUrl {
|
|
* prepopulated_engines.json.
|
|
*/
|
|
public String getNewTabURL() {
|
|
+ if ((true)) return null;
|
|
return TemplateUrlJni.get().getNewTabURL(mTemplateUrlPtr);
|
|
}
|
|
|
|
diff --git a/components/search_engines/android/template_url_service_android.cc b/components/search_engines/android/template_url_service_android.cc
|
|
--- a/components/search_engines/android/template_url_service_android.cc
|
|
+++ b/components/search_engines/android/template_url_service_android.cc
|
|
@@ -426,6 +426,7 @@ bool TemplateUrlServiceAndroid::SetPlayAPISearchEngine(
|
|
jimage_translate_source_language_param_key,
|
|
const base::android::JavaRef<jstring>&
|
|
jimage_translate_target_language_param_key) {
|
|
+ if ((true)) return false;
|
|
// The function is scheduled to run only when the service is loaded, see
|
|
// `TemplateUrlService#runWhenLoaded()`.
|
|
CHECK(template_url_service_->loaded());
|
|
diff --git a/cromite_flags/chrome/browser/flags/android/chrome_feature_list_cc/always-use-new-tab-page-for-default-home-page.inc b/cromite_flags/chrome/browser/flags/android/chrome_feature_list_cc/always-use-new-tab-page-for-default-home-page.inc
|
|
new file mode 100755
|
|
--- /dev/null
|
|
+++ b/cromite_flags/chrome/browser/flags/android/chrome_feature_list_cc/always-use-new-tab-page-for-default-home-page.inc
|
|
@@ -0,0 +1 @@
|
|
+SET_CROMITE_FEATURE_DISABLED(kPartnerCustomizationsUma);
|
|
--
|