From: csagan5 <32685696+csagan5@users.noreply.github.com> Date: Thu, 27 Feb 2020 23:23:59 +0100 Subject: Do not compile QR code sharing --- chrome/android/java/AndroidManifest.xml | 16 --------------- .../ChromeProvidedSharingOptionsProvider.java | 20 +------------------ .../browser/share/ShareDelegateImpl.java | 5 ----- .../browser/share/ShareSheetCoordinator.java | 5 +---- chrome/browser/share/android/java_sources.gni | 19 ------------------ 5 files changed, 2 insertions(+), 63 deletions(-) diff --git a/chrome/android/java/AndroidManifest.xml b/chrome/android/java/AndroidManifest.xml --- a/chrome/android/java/AndroidManifest.xml +++ b/chrome/android/java/AndroidManifest.xml @@ -755,22 +755,6 @@ by a child template that "extends" this file. - - - - - - - { - RecordUserAction.record("SharingHubAndroid.QRCodeSelected"); - RecordHistogram.recordMediumTimesHistogram( - "Sharing.SharingHubAndroid.TimeToShare", - System.currentTimeMillis() - mShareStartTime); - mBottomSheetController.hideContent(mBottomSheetContent, true); - QrCodeCoordinator qrCodeCoordinator = new QrCodeCoordinator(mActivity); - qrCodeCoordinator.show(); - }, - /*isFirstParty=*/true); - } - PropertyModel createPrintingPropertyModel() { return ShareSheetPropertyModelBuilder.createPropertyModel( AppCompatResources.getDrawable(mActivity, R.drawable.sharing_print), @@ -177,4 +159,4 @@ class ChromeProvidedSharingOptionsProvider { }, /*isFirstParty=*/true); } -} \ No newline at end of file +} diff --git a/chrome/android/java/src/org/chromium/chrome/browser/share/ShareDelegateImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/share/ShareDelegateImpl.java --- a/chrome/android/java/src/org/chromium/chrome/browser/share/ShareDelegateImpl.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/share/ShareDelegateImpl.java @@ -21,7 +21,6 @@ import org.chromium.chrome.browser.offlinepages.OfflinePageUtils; import org.chromium.chrome.browser.preferences.PrefServiceBridge; import org.chromium.chrome.browser.printing.PrintShareActivity; import org.chromium.chrome.browser.send_tab_to_self.SendTabToSelfShareActivity; -import org.chromium.chrome.browser.share.qrcode.QrCodeShareActivity; import org.chromium.chrome.browser.tab.SadTab; import org.chromium.chrome.browser.tab.Tab; import org.chromium.chrome.browser.tab.TabImpl; @@ -103,10 +102,6 @@ public class ShareDelegateImpl implements ShareDelegate { classesToEnable.add(SendTabToSelfShareActivity.class); } - if (QrCodeShareActivity.featureIsAvailable()) { - classesToEnable.add(QrCodeShareActivity.class); - } - if (!classesToEnable.isEmpty()) { OptionalShareTargetsManager.getInstance().enableOptionalShareActivities(activity, classesToEnable, () -> triggerShare(currentTab, shareDirectly, isIncognito)); diff --git a/chrome/android/java/src/org/chromium/chrome/browser/share/ShareSheetCoordinator.java b/chrome/android/java/src/org/chromium/chrome/browser/share/ShareSheetCoordinator.java --- a/chrome/android/java/src/org/chromium/chrome/browser/share/ShareSheetCoordinator.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/share/ShareSheetCoordinator.java @@ -81,9 +81,6 @@ class ShareSheetCoordinator { } models.add(chromeProvidedSharingOptionsProvider.createCopyLinkPropertyModel()); models.add(chromeProvidedSharingOptionsProvider.createSendTabToSelfPropertyModel()); - if (ChromeFeatureList.isEnabled(ChromeFeatureList.CHROME_SHARE_QRCODE)) { - models.add(chromeProvidedSharingOptionsProvider.createQrCodePropertyModel()); - } if (mPrefServiceBridge.getBoolean(Pref.PRINTING_ENABLED)) { models.add(chromeProvidedSharingOptionsProvider.createPrintingPropertyModel()); } @@ -111,4 +108,4 @@ class ShareSheetCoordinator { return models; } -} \ No newline at end of file +} diff --git a/chrome/browser/share/android/java_sources.gni b/chrome/browser/share/android/java_sources.gni --- a/chrome/browser/share/android/java_sources.gni +++ b/chrome/browser/share/android/java_sources.gni @@ -8,24 +8,5 @@ share_java_sources = [ "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/SaveImageNotificationManager.java", "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/ShareImageFileUtils.java", "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/clipboard/ClipboardImageFileProvider.java", - "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/QRCodeGenerationRequest.java", - "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/QrCodeCoordinator.java", - "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/QrCodeDialog.java", - "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/QrCodeDialogTab.java", - "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/QrCodePageAdapter.java", - "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/QrCodeShareActivity.java", - "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/TabLayoutPageListener.java", - "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/scan_tab/CameraPreview.java", - "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/scan_tab/CameraPreviewOverlay.java", - "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/scan_tab/QrCodeScanCoordinator.java", - "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/scan_tab/QrCodeScanMediator.java", - "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/scan_tab/QrCodeScanView.java", - "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/scan_tab/QrCodeScanViewBinder.java", - "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/scan_tab/QrCodeScanViewProperties.java", - "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/share_tab/QrCodeShareCoordinator.java", - "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/share_tab/QrCodeShareMediator.java", - "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/share_tab/QrCodeShareView.java", - "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/share_tab/QrCodeShareViewBinder.java", - "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/qrcode/share_tab/QrCodeShareViewProperties.java", "//chrome/browser/share/android/java/src/org/chromium/chrome/browser/share/screenshot/ScreenshotCoordinator.java", ] -- 2.17.1