From: uazo Date: Mon, 15 Nov 2021 09:43:29 +0000 Subject: Disable conversion measurement api Disable Conversion Measurement API by disabling the flag and removing support for the AttributionReporting provider. it also removes the handling of attributions via intents between apps. This patch enforces the deactivation by preventing the report from being sent and being saved to disk, although it is currently in uncalled code. --- chrome/android/java/AndroidManifest.xml | 8 -------- .../AttributionIntentHandlerFactory.java | 9 +-------- .../browser/flags/android/chrome_feature_list.cc | 2 +- .../embedder_support/origin_trials/features.cc | 3 ++- .../render_view_context_menu_base.cc | 3 --- .../browser/android/navigation_handle_proxy.cc | 10 ---------- .../attribution_reporting/attribution_host.cc | 8 -------- .../attribution_reporting/attribution_host.h | 3 --- .../attribution_host_utils.cc | 6 ++++++ .../attribution_network_sender_impl.cc | 15 ++++++++------- .../attribution_storage_sql.cc | 2 +- .../navigation_controller_android.cc | 16 ---------------- content/browser/storage_partition_impl.cc | 7 +------ .../content/browser/AttributionReporterImpl.java | 4 ---- content/public/browser/navigation_controller.cc | 1 - third_party/blink/common/features.cc | 2 +- .../platform/runtime_enabled_features.json5 | 13 +++++++++---- 17 files changed, 30 insertions(+), 82 deletions(-) diff --git a/chrome/android/java/AndroidManifest.xml b/chrome/android/java/AndroidManifest.xml --- a/chrome/android/java/AndroidManifest.xml +++ b/chrome/android/java/AndroidManifest.xml @@ -1259,14 +1259,6 @@ by a child template that "extends" this file. android:readPermission="android.permission.GLOBAL_SEARCH" /> - - - - {% block base_application_definitions %} {% endblock %} {% block extra_application_definitions_for_test %} diff --git a/chrome/browser/attribution_reporting/android/internal/java/src/org/chromium/chrome/browser/attribution_reporting/AttributionIntentHandlerFactory.java b/chrome/browser/attribution_reporting/android/internal/java/src/org/chromium/chrome/browser/attribution_reporting/AttributionIntentHandlerFactory.java --- a/chrome/browser/attribution_reporting/android/internal/java/src/org/chromium/chrome/browser/attribution_reporting/AttributionIntentHandlerFactory.java +++ b/chrome/browser/attribution_reporting/android/internal/java/src/org/chromium/chrome/browser/attribution_reporting/AttributionIntentHandlerFactory.java @@ -26,14 +26,7 @@ public class AttributionIntentHandlerFactory { * @return an AttributionIntentHandler instance. */ public static AttributionIntentHandler getInstance() { - if (CachedFeatureFlags.isEnabled(ChromeFeatureList.APP_TO_WEB_ATTRIBUTION)) { - if (sIntentHandler == null) { - sIntentHandler = new AttributionIntentHandlerImpl(sValidator); - } - return sIntentHandler; - } else { - return new NoopAttributionIntentHandler(); - } + return new NoopAttributionIntentHandler(); } public static void setInputEventValidatorForTesting(Predicate validator) { diff --git a/chrome/browser/flags/android/chrome_feature_list.cc b/chrome/browser/flags/android/chrome_feature_list.cc --- a/chrome/browser/flags/android/chrome_feature_list.cc +++ b/chrome/browser/flags/android/chrome_feature_list.cc @@ -448,7 +448,7 @@ const base::Feature kAppMenuMobileSiteOption{"AppMenuMobileSiteOption", base::FEATURE_DISABLED_BY_DEFAULT}; const base::Feature kAppToWebAttribution{"AppToWebAttribution", - base::FEATURE_DISABLED_BY_DEFAULT}; + base::FEATURE_DISABLED_BY_DEFAULT}; // guard this const base::Feature kBackgroundThreadPool{"BackgroundThreadPool", base::FEATURE_DISABLED_BY_DEFAULT}; diff --git a/components/embedder_support/origin_trials/features.cc b/components/embedder_support/origin_trials/features.cc --- a/components/embedder_support/origin_trials/features.cc +++ b/components/embedder_support/origin_trials/features.cc @@ -17,8 +17,9 @@ const base::Feature kOriginTrialsSampleAPIThirdPartyAlternativeUsage{ "OriginTrialsSampleAPIThirdPartyAlternativeUsage", base::FEATURE_ENABLED_BY_DEFAULT}; +// When disabled, the API cannot be enabled by tokens. const base::Feature kConversionMeasurementAPIAlternativeUsage{ "ConversionMeasurementAPIAlternativeUsage", - base::FEATURE_ENABLED_BY_DEFAULT}; + base::FEATURE_DISABLED_BY_DEFAULT}; } // namespace embedder_support diff --git a/components/renderer_context_menu/render_view_context_menu_base.cc b/components/renderer_context_menu/render_view_context_menu_base.cc --- a/components/renderer_context_menu/render_view_context_menu_base.cc +++ b/components/renderer_context_menu/render_view_context_menu_base.cc @@ -485,9 +485,6 @@ void RenderViewContextMenuBase::OpenURLWithExtraHeaders( open_url_params.source_site_instance = site_instance_; - if (disposition != WindowOpenDisposition::OFF_THE_RECORD) - open_url_params.impression = params_.impression; - source_web_contents_->OpenURL(open_url_params); } diff --git a/content/browser/android/navigation_handle_proxy.cc b/content/browser/android/navigation_handle_proxy.cc --- a/content/browser/android/navigation_handle_proxy.cc +++ b/content/browser/android/navigation_handle_proxy.cc @@ -30,16 +30,6 @@ NavigationHandleProxy::NavigationHandleProxy( base::android::ScopedJavaLocalRef impression_byte_buffer = nullptr; // Scoped to out-live the java call as this uses a DirectByteBuffer. - std::vector byte_vector; - if (cpp_navigation_handle_->GetImpression()) { - blink::mojom::ImpressionPtr impression = - AttributionHost::MojoImpressionFromImpression( - *cpp_navigation_handle_->GetImpression()); - byte_vector = blink::mojom::Impression::Serialize(&impression); - impression_byte_buffer = base::android::ScopedJavaLocalRef( - env, env->NewDirectByteBuffer(byte_vector.data(), byte_vector.size())); - base::android::CheckException(env); - } java_navigation_handle_ = Java_NavigationHandle_Constructor( env, reinterpret_cast(this), url::GURLAndroid::FromNativeGURL(env, cpp_navigation_handle_->GetURL()), diff --git a/content/browser/attribution_reporting/attribution_host.cc b/content/browser/attribution_reporting/attribution_host.cc --- a/content/browser/attribution_reporting/attribution_host.cc +++ b/content/browser/attribution_reporting/attribution_host.cc @@ -471,14 +471,6 @@ void AttributionHost::BindReceiver( conversion_host->receivers_.Bind(rfh, std::move(receiver)); } -// static -blink::mojom::ImpressionPtr AttributionHost::MojoImpressionFromImpression( - const blink::Impression& impression) { - return blink::mojom::Impression::New( - impression.conversion_destination, impression.reporting_origin, - impression.impression_data, impression.expiry, impression.priority); -} - // static void AttributionHost::SetReceiverImplForTesting(AttributionHost* impl) { g_receiver_for_testing = impl; diff --git a/content/browser/attribution_reporting/attribution_host.h b/content/browser/attribution_reporting/attribution_host.h --- a/content/browser/attribution_reporting/attribution_host.h +++ b/content/browser/attribution_reporting/attribution_host.h @@ -57,9 +57,6 @@ class CONTENT_EXPORT AttributionHost const url::Origin& impression_origin, const blink::Impression& impression); - static blink::mojom::ImpressionPtr MojoImpressionFromImpression( - const blink::Impression& impression); - // Overrides the target object to bind |receiver| to in BindReceiver(). static void SetReceiverImplForTesting(AttributionHost* impl); diff --git a/content/browser/attribution_reporting/attribution_host_utils.cc b/content/browser/attribution_reporting/attribution_host_utils.cc --- a/content/browser/attribution_reporting/attribution_host_utils.cc +++ b/content/browser/attribution_reporting/attribution_host_utils.cc @@ -20,6 +20,8 @@ #include "url/gurl.h" #include "url/origin.h" +// will change in attribution_host_utils.cc + namespace content { namespace attribution_host_utils { @@ -81,6 +83,10 @@ absl::optional ParseImpressionFromApp( // Java API should have rejected these already. DCHECK(!source_event_id.empty() && !destination.empty()); + // no impression from app + if ((true)) + return absl::nullopt; + blink::Impression impression; if (!base::StringToUint64(source_event_id, &impression.impression_data)) return absl::nullopt; diff --git a/content/browser/attribution_reporting/attribution_network_sender_impl.cc b/content/browser/attribution_reporting/attribution_network_sender_impl.cc --- a/content/browser/attribution_reporting/attribution_network_sender_impl.cc +++ b/content/browser/attribution_reporting/attribution_network_sender_impl.cc @@ -116,13 +116,8 @@ void AttributionNetworkSenderImpl::SendReport( network::SimpleURLLoader::RETRY_ON_NAME_NOT_RESOLVED; simple_url_loader_ptr->SetRetryOptions(/*max_retries=*/1, retry_mode); - // Unretained is safe because the URLLoader is owned by |this| and will be - // deleted before |this|. - simple_url_loader_ptr->DownloadHeadersOnly( - url_loader_factory_.get(), - base::BindOnce(&AttributionNetworkSenderImpl::OnReportSent, - base::Unretained(this), std::move(it), std::move(report), - std::move(sent_callback))); + // this is never called on Bromite but nothing would be sent if it were + OnReportSent(std::move(it), report, std::move(sent_callback), nullptr); } void AttributionNetworkSenderImpl::SetURLLoaderFactoryForTesting( @@ -135,6 +130,12 @@ void AttributionNetworkSenderImpl::OnReportSent( AttributionReport report, ReportSentCallback sent_callback, scoped_refptr headers) { + if ((true)) { + std::move(sent_callback) + .Run(std::move(report), + SendResult(SendResult::Status::kSent, headers ? headers->response_code() : 200)); + return; + } network::SimpleURLLoader* loader = it->get(); // Consider a non-200 HTTP code as a non-internal error. diff --git a/content/browser/attribution_reporting/attribution_storage_sql.cc b/content/browser/attribution_reporting/attribution_storage_sql.cc --- a/content/browser/attribution_reporting/attribution_storage_sql.cc +++ b/content/browser/attribution_reporting/attribution_storage_sql.cc @@ -353,7 +353,7 @@ void AttributionStorageSql::RunInMemoryForTesting() { } // static -bool AttributionStorageSql::g_run_in_memory_ = false; +bool AttributionStorageSql::g_run_in_memory_ = true; AttributionStorageSql::AttributionStorageSql( const base::FilePath& path_to_database, diff --git a/content/browser/renderer_host/navigation_controller_android.cc b/content/browser/renderer_host/navigation_controller_android.cc --- a/content/browser/renderer_host/navigation_controller_android.cc +++ b/content/browser/renderer_host/navigation_controller_android.cc @@ -319,22 +319,6 @@ void NavigationControllerAndroid::LoadUrl( if (input_start != 0) params.input_start = base::TimeTicks::FromUptimeMillis(input_start); - if (source_package_name) { - DCHECK(!params.initiator_origin); - // At the moment, source package name is only used for attribution. - DCHECK(attribution_source_event_id); - params.initiator_origin = OriginFromAndroidPackageName( - ConvertJavaStringToUTF8(env, source_package_name)); - - params.impression = attribution_host_utils::ParseImpressionFromApp( - ConvertJavaStringToUTF8(env, attribution_source_event_id), - ConvertJavaStringToUTF8(env, attribution_destination), - attribution_report_to - ? ConvertJavaStringToUTF8(env, attribution_report_to) - : "", - attribution_expiry); - } - params.override_user_agent = static_cast( user_agent_override_option); diff --git a/content/browser/storage_partition_impl.cc b/content/browser/storage_partition_impl.cc --- a/content/browser/storage_partition_impl.cc +++ b/content/browser/storage_partition_impl.cc @@ -1303,12 +1303,7 @@ void StoragePartitionImpl::Initialize( bucket_context_ = base::MakeRefCounted(); bucket_context_->Initialize(quota_manager_proxy); - // The Conversion Measurement API is not available in Incognito mode. - if (!is_in_memory() && - base::FeatureList::IsEnabled(blink::features::kConversionMeasurement)) { - attribution_manager_ = std::make_unique( - this, path, special_storage_policy_); - } + // The Conversion Measurement API is not available in Bromite. if (base::FeatureList::IsEnabled(blink::features::kInterestGroupStorage)) { interest_group_manager_ = std::make_unique( diff --git a/content/public/android/java/src/org/chromium/content/browser/AttributionReporterImpl.java b/content/public/android/java/src/org/chromium/content/browser/AttributionReporterImpl.java --- a/content/public/android/java/src/org/chromium/content/browser/AttributionReporterImpl.java +++ b/content/public/android/java/src/org/chromium/content/browser/AttributionReporterImpl.java @@ -22,8 +22,6 @@ public class AttributionReporterImpl extends AttributionReporter { public void reportAttributionForCurrentNavigation(WebContents webContents, String sourcePackageName, String sourceEventId, String destination, String reportTo, long expiry) { - AttributionReporterImplJni.get().reportAttributionForCurrentNavigation( - webContents, sourcePackageName, sourceEventId, destination, reportTo, expiry); } /** @@ -33,8 +31,6 @@ public class AttributionReporterImpl extends AttributionReporter { public void reportAppImpression(BrowserContextHandle browserContext, String sourcePackageName, String sourceEventId, String destination, String reportTo, long expiry, long eventTime) { - AttributionReporterImplJni.get().reportAppImpression(browserContext, sourcePackageName, - sourceEventId, destination, reportTo, expiry, eventTime); } @NativeMethods diff --git a/content/public/browser/navigation_controller.cc b/content/public/browser/navigation_controller.cc --- a/content/public/browser/navigation_controller.cc +++ b/content/public/browser/navigation_controller.cc @@ -36,7 +36,6 @@ NavigationController::LoadURLParams::LoadURLParams(const OpenURLParams& input) blob_url_loader_factory(input.blob_url_loader_factory), href_translate(input.href_translate), reload_type(input.reload_type), - impression(input.impression), is_pdf(input.is_pdf) { #if DCHECK_IS_ON() DCHECK(input.Valid()); diff --git a/third_party/blink/common/features.cc b/third_party/blink/common/features.cc --- a/third_party/blink/common/features.cc +++ b/third_party/blink/common/features.cc @@ -43,7 +43,7 @@ const base::Feature kCSSContainerQueries{"CSSContainerQueries", // Controls whether the Conversion Measurement API infrastructure is enabled. const base::Feature kConversionMeasurement{"ConversionMeasurement", - base::FEATURE_ENABLED_BY_DEFAULT}; + base::FEATURE_DISABLED_BY_DEFAULT}; // Controls whether LCP calculations should exclude low-entropy images. If // enabled, then the associated parameter sets the cutoff, expressed as the diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5 b/third_party/blink/renderer/platform/runtime_enabled_features.json5 --- a/third_party/blink/renderer/platform/runtime_enabled_features.json5 +++ b/third_party/blink/renderer/platform/runtime_enabled_features.json5 @@ -106,6 +106,13 @@ }, data: [ + { + // disable by default features by marking as + // depends_on: ["DisabledForBromite"] + // to work is needed to remove "origin_trial_feature_name" + // and "origin_trial_allows_third_party" + name: "DisabledForBromite", + }, { name: "AbortSignalThrowIfAborted", status: "stable", @@ -493,13 +500,11 @@ }, { name: "ConversionMeasurement", - origin_trial_feature_name: "ConversionMeasurement", - origin_trial_allows_third_party: true, - status: "experimental", + depends_on: ["DisabledForBromite"], }, { name: "ConversionMeasurementEventSources", - status: "test", + depends_on: ["DisabledForBromite"], }, { name: "CooperativeScheduling" -- 2.25.1