From: uazo Date: Sun, 7 May 2023 13:13:47 +0000 Subject: Disable GetInstalledRelatedApps API License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html --- .../components/installedapp/InstalledAppProviderImpl.java | 1 + .../browser/installedapp/installed_app_provider_impl.cc | 2 +- .../features_cc/Disable-GetInstalledRelatedApps-API.inc | 7 +++++++ .../Disable-GetInstalledRelatedApps-API.inc | 2 ++ .../blink/renderer/platform/runtime_enabled_features.json5 | 3 +-- 5 files changed, 12 insertions(+), 3 deletions(-) create mode 100644 cromite_flags/content/common/features_cc/Disable-GetInstalledRelatedApps-API.inc create mode 100644 cromite_flags/content/public/common/content_features_cc/Disable-GetInstalledRelatedApps-API.inc diff --git a/components/installedapp/android/java/src/org/chromium/components/installedapp/InstalledAppProviderImpl.java b/components/installedapp/android/java/src/org/chromium/components/installedapp/InstalledAppProviderImpl.java --- a/components/installedapp/android/java/src/org/chromium/components/installedapp/InstalledAppProviderImpl.java +++ b/components/installedapp/android/java/src/org/chromium/components/installedapp/InstalledAppProviderImpl.java @@ -137,6 +137,7 @@ public class InstalledAppProviderImpl implements InstalledAppProvider { final Url manifestUrl, final boolean addSavedRelatedApplications, final FilterInstalledApps_Response callback) { + assert false; GURL url = mRenderFrameHost.getLastCommittedURL(); final GURL frameUrl = url == null ? GURL.emptyGURL() : url; int numTasks = Math.min(relatedApps.length, MAX_ALLOWED_RELATED_APPS); diff --git a/content/browser/installedapp/installed_app_provider_impl.cc b/content/browser/installedapp/installed_app_provider_impl.cc --- a/content/browser/installedapp/installed_app_provider_impl.cc +++ b/content/browser/installedapp/installed_app_provider_impl.cc @@ -62,7 +62,7 @@ void InstalledAppProviderImpl::FilterInstalledApps( bool add_saved_related_applications, FilterInstalledAppsCallback callback) { DCHECK_CALLED_ON_VALID_SEQUENCE(sequence_checker_); - if (!base::FeatureList::IsEnabled(features::kInstalledAppProvider)) { + if ((true)) { base::SequencedTaskRunner::GetCurrentDefault()->PostTask( FROM_HERE, base::BindOnce(std::move(callback), diff --git a/cromite_flags/content/common/features_cc/Disable-GetInstalledRelatedApps-API.inc b/cromite_flags/content/common/features_cc/Disable-GetInstalledRelatedApps-API.inc new file mode 100644 --- /dev/null +++ b/cromite_flags/content/common/features_cc/Disable-GetInstalledRelatedApps-API.inc @@ -0,0 +1,7 @@ +SET_CROMITE_FEATURE_DISABLED(kFilterInstalledAppsWebAppMatching); + +#if BUILDFLAG(IS_WIN) + +SET_CROMITE_FEATURE_DISABLED(kFilterInstalledAppsWinMatching); + +#endif diff --git a/cromite_flags/content/public/common/content_features_cc/Disable-GetInstalledRelatedApps-API.inc b/cromite_flags/content/public/common/content_features_cc/Disable-GetInstalledRelatedApps-API.inc new file mode 100644 --- /dev/null +++ b/cromite_flags/content/public/common/content_features_cc/Disable-GetInstalledRelatedApps-API.inc @@ -0,0 +1,2 @@ +SET_CROMITE_FEATURE_DISABLED(kInstalledApp); +SET_CROMITE_FEATURE_DISABLED(kInstalledAppProvider); diff --git a/third_party/blink/renderer/platform/runtime_enabled_features.json5 b/third_party/blink/renderer/platform/runtime_enabled_features.json5 --- a/third_party/blink/renderer/platform/runtime_enabled_features.json5 +++ b/third_party/blink/renderer/platform/runtime_enabled_features.json5 @@ -3386,9 +3386,8 @@ status: "stable", }, { - name: "InstalledApp", + name: "InstalledApp", // disable GetInstalledRelatedApps public: true, - status: "stable", base_feature: "none", }, { --