From: uazo Date: Tue, 14 Mar 2023 15:59:38 +0000 Subject: Disable privacy issues in password manager License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html --- chrome/android/java/AndroidManifest.xml | 9 --------- .../generated_password_leak_detection_pref.cc | 3 +-- .../affiliations/core/browser/affiliation_backend.cc | 1 + .../core/browser/affiliation_service_impl.cc | 4 ++++ components/affiliations/core/browser/facet_manager.cc | 4 ++++ .../core/browser/features/password_features.cc | 4 ++++ .../leak_detection/leak_detection_check_factory_impl.cc | 5 +++++ .../browser/leak_detection/leak_detection_check_impl.cc | 4 +--- 8 files changed, 20 insertions(+), 14 deletions(-) diff --git a/chrome/android/java/AndroidManifest.xml b/chrome/android/java/AndroidManifest.xml --- a/chrome/android/java/AndroidManifest.xml +++ b/chrome/android/java/AndroidManifest.xml @@ -450,15 +450,6 @@ by a child template that "extends" this file. - - - - - - - diff --git a/chrome/browser/password_manager/generated_password_leak_detection_pref.cc b/chrome/browser/password_manager/generated_password_leak_detection_pref.cc --- a/chrome/browser/password_manager/generated_password_leak_detection_pref.cc +++ b/chrome/browser/password_manager/generated_password_leak_detection_pref.cc @@ -20,8 +20,7 @@ namespace { // Returns whether the user can use the leak detection feature. bool IsUserAllowedToUseLeakDetection(Profile* profile) { - return !profile->IsGuestSession() && - IdentityManagerFactory::GetForProfileIfExists(profile); + return false; } // Returns whether the effective value of the Safe Browsing preferences for diff --git a/components/affiliations/core/browser/affiliation_backend.cc b/components/affiliations/core/browser/affiliation_backend.cc --- a/components/affiliations/core/browser/affiliation_backend.cc +++ b/components/affiliations/core/browser/affiliation_backend.cc @@ -397,6 +397,7 @@ void AffiliationBackend::OnMalformedResponse( } bool AffiliationBackend::OnCanSendNetworkRequest() { + if ((true)) return false; DCHECK(!fetcher_); std::vector requested_facet_uris; for (const auto& facet_manager_pair : facet_managers_) { diff --git a/components/affiliations/core/browser/affiliation_service_impl.cc b/components/affiliations/core/browser/affiliation_service_impl.cc --- a/components/affiliations/core/browser/affiliation_service_impl.cc +++ b/components/affiliations/core/browser/affiliation_service_impl.cc @@ -127,6 +127,10 @@ void AffiliationServiceImpl::Shutdown() { void AffiliationServiceImpl::PrefetchChangePasswordURLs( const std::vector& urls, base::OnceClosure callback) { + if ((true)) { + std::move(callback).Run(); + return; + } std::vector facets; std::vector tuple_origins; for (const auto& url : urls) { diff --git a/components/affiliations/core/browser/facet_manager.cc b/components/affiliations/core/browser/facet_manager.cc --- a/components/affiliations/core/browser/facet_manager.cc +++ b/components/affiliations/core/browser/facet_manager.cc @@ -117,6 +117,10 @@ void FacetManager::GetAffiliationsAndBranding( RequestInfo request_info; request_info.callback = std::move(callback); request_info.callback_task_runner = callback_task_runner; + if ((true)) { + ServeRequestWithFailure(std::move(request_info)); + return; + } if (IsCachedDataFresh()) { AffiliatedFacetsWithUpdateTime affiliation; if (!backend_->ReadAffiliationsAndBrandingFromDatabase(facet_uri_, diff --git a/components/password_manager/core/browser/features/password_features.cc b/components/password_manager/core/browser/features/password_features.cc --- a/components/password_manager/core/browser/features/password_features.cc +++ b/components/password_manager/core/browser/features/password_features.cc @@ -176,4 +176,8 @@ BASE_FEATURE(kUseGMSCoreForBrandingInfo, base::FEATURE_DISABLED_BY_DEFAULT); #endif +SET_CROMITE_FEATURE_ENABLED(kFillOnAccountSelect); +SET_CROMITE_FEATURE_DISABLED(kPasswordManagerEnableReceiverService); +SET_CROMITE_FEATURE_DISABLED(kPasswordManagerEnableSenderService); + } // namespace password_manager::features diff --git a/components/password_manager/core/browser/leak_detection/leak_detection_check_factory_impl.cc b/components/password_manager/core/browser/leak_detection/leak_detection_check_factory_impl.cc --- a/components/password_manager/core/browser/leak_detection/leak_detection_check_factory_impl.cc +++ b/components/password_manager/core/browser/leak_detection/leak_detection_check_factory_impl.cc @@ -46,6 +46,11 @@ LeakDetectionCheckFactoryImpl::TryCreateLeakCheck( version_info::Channel channel) const { CHECK(identity_manager); + if ((true)) { + delegate->OnError(LeakDetectionError::kNotSignIn); + return nullptr; + } + return std::make_unique( delegate, identity_manager, std::move(url_loader_factory), GetAPIKey(LeakDetectionCheckImpl::HasAccountForRequest(identity_manager), diff --git a/components/password_manager/core/browser/leak_detection/leak_detection_check_impl.cc b/components/password_manager/core/browser/leak_detection/leak_detection_check_impl.cc --- a/components/password_manager/core/browser/leak_detection/leak_detection_check_impl.cc +++ b/components/password_manager/core/browser/leak_detection/leak_detection_check_impl.cc @@ -194,9 +194,7 @@ bool LeakDetectionCheckImpl::HasAccountForRequest( // always return something if the user is signed in. // On Android it will be empty if the user isn't syncing. Thus, // GetAccountsWithRefreshTokens() check is necessary. - return identity_manager && - (identity_manager->HasPrimaryAccount(signin::ConsentLevel::kSignin) || - !identity_manager->GetAccountsWithRefreshTokens().empty()); + return false; } void LeakDetectionCheckImpl::Start(LeakDetectionInitiator initiator, --