From e37ccd0330d8c90c4a84ddfe6b2fe00a5e182e50 Mon Sep 17 00:00:00 2001 From: Carmelo Messina Date: Sat, 7 May 2022 16:12:51 +0200 Subject: [PATCH] fix odd behaviour with search or site suggestions --- .../Move-navigation-bar-to-bottom.patch | 27 ++++++++++++++++++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/build/patches/Move-navigation-bar-to-bottom.patch b/build/patches/Move-navigation-bar-to-bottom.patch index 0521dbd1..38c07c99 100644 --- a/build/patches/Move-navigation-bar-to-bottom.patch +++ b/build/patches/Move-navigation-bar-to-bottom.patch @@ -58,6 +58,7 @@ Support for tablet mode is also included. .../omnibox/LocationBarCoordinator.java | 9 +++- .../browser/omnibox/UrlBarCoordinator.java | 11 +++- .../suggestions/AutocompleteCoordinator.java | 16 +++++- + .../suggestions/AutocompleteMediator.java | 7 ++- .../OmniboxSuggestionsDropdown.java | 23 +++++++- .../OmniboxSuggestionsDropdownEmbedder.java | 4 ++ .../strings/android_chrome_strings.grd | 6 +++ @@ -77,7 +78,7 @@ Support for tablet mode is also included. .../accessibility/AccessibilitySettings.java | 16 ++++++ .../AccessibilitySettingsDelegate.java | 6 +++ .../render_widget_host_view_android.cc | 3 ++ - 68 files changed, 723 insertions(+), 52 deletions(-) + 69 files changed, 729 insertions(+), 53 deletions(-) diff --git a/cc/base/features.cc b/cc/base/features.cc --- a/cc/base/features.cc @@ -1766,6 +1767,30 @@ diff --git a/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/brow mHolder = new SuggestionListViewHolder(container, dropdown); for (int i = 0; i < mCallbacks.size(); i++) { +diff --git a/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteMediator.java b/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteMediator.java +--- a/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteMediator.java ++++ b/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/AutocompleteMediator.java +@@ -55,6 +55,9 @@ import org.chromium.ui.modelutil.PropertyModel; + import org.chromium.ui.mojom.WindowOpenDisposition; + import org.chromium.url.GURL; + ++import org.chromium.chrome.browser.flags.ChromeFeatureList; ++import org.chromium.chrome.browser.flags.CachedFeatureFlags; ++ + import java.lang.annotation.Retention; + import java.lang.annotation.RetentionPolicy; + import java.util.List; +@@ -935,7 +938,9 @@ class AutocompleteMediator implements OnSuggestionsReceivedListener, + public void onSuggestionDropdownScroll() { + if (mDropdownViewInfoListBuilder.hasFullyConcealedElements()) { + mSuggestionsListScrolled = true; +- mDelegate.setKeyboardVisibility(false, false); ++ if (!CachedFeatureFlags.isEnabled(ChromeFeatureList.MOVE_TOP_TOOLBAR_TO_BOTTOM)) { ++ mDelegate.setKeyboardVisibility(false, false); ++ } + } + } + diff --git a/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionsDropdown.java b/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionsDropdown.java --- a/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionsDropdown.java +++ b/chrome/browser/ui/android/omnibox/java/src/org/chromium/chrome/browser/omnibox/suggestions/OmniboxSuggestionsDropdown.java