From c512845991255787b2231acccb4eae7659527045 Mon Sep 17 00:00:00 2001 From: Carmelo Messina Date: Sat, 3 Aug 2024 17:21:18 +0200 Subject: [PATCH] Fix "Welcome screen" modifies the same line as Fix-chromium-vanilla.patch (#1340) --- build/patches/Welcome-screen.patch | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/build/patches/Welcome-screen.patch b/build/patches/Welcome-screen.patch index f8ebab82..815d6aa8 100644 --- a/build/patches/Welcome-screen.patch +++ b/build/patches/Welcome-screen.patch @@ -15,13 +15,13 @@ License: GPL-3.0-only - https://spdx.org/licenses/GPL-3.0-only.html .../DefaultSearchEngineFirstRunFragment.java | 3 - .../browser/firstrun/FirstRunActivity.java | 31 +- .../firstrun/FirstRunActivityBase.java | 6 +- - .../firstrun/FirstRunFlowSequencer.java | 68 +--- + .../firstrun/FirstRunFlowSequencer.java | 70 +--- .../browser/firstrun/FirstRunUtils.java | 1 + .../firstrun/ToSAndUMAFirstRunFragment.java | 335 +++++++++++++++++ .../firstrun/TosAndUmaFragmentView.java | 336 ++++++++++++++++++ .../browser/locale/LocaleManagerDelegate.java | 5 +- .../strings/android_chrome_strings.grd | 24 +- - 15 files changed, 911 insertions(+), 108 deletions(-) + 15 files changed, 911 insertions(+), 110 deletions(-) create mode 100644 chrome/android/java/res/layout/fre_tosanduma.xml create mode 100644 chrome/android/java/src/org/chromium/chrome/browser/firstrun/ToSAndUMAFirstRunFragment.java create mode 100644 chrome/android/java/src/org/chromium/chrome/browser/firstrun/TosAndUmaFragmentView.java @@ -513,16 +513,18 @@ diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstR onFlowIsKnown(freProperties); } -@@ -206,6 +158,8 @@ public abstract class FirstRunFlowSequencer { +@@ -206,8 +158,8 @@ public abstract class FirstRunFlowSequencer { * @param freProperties Resulting FRE properties bundle. */ public void updateFirstRunProperties(Bundle freProperties) { +- // fix chromium vanilla startup +- if (freProperties == null) return; + if (freProperties == null) + throw new RuntimeException("attempting to update null FRE properties"); boolean isHistorySyncEnabled = ChromeFeatureList.isEnabled( ChromeFeatureList.REPLACE_SYNC_PROMOS_WITH_SIGN_IN_PROMOS); -@@ -320,13 +274,17 @@ public abstract class FirstRunFlowSequencer { +@@ -322,13 +274,17 @@ public abstract class FirstRunFlowSequencer { if (!(caller instanceof Activity)) { freIntent.addFlags(Intent.FLAG_ACTIVITY_NEW_TASK); } @@ -1252,7 +1254,7 @@ diff --git a/chrome/browser/locale/java/src/org/chromium/chrome/browser/locale/L diff --git a/chrome/browser/ui/android/strings/android_chrome_strings.grd b/chrome/browser/ui/android/strings/android_chrome_strings.grd --- a/chrome/browser/ui/android/strings/android_chrome_strings.grd +++ b/chrome/browser/ui/android/strings/android_chrome_strings.grd -@@ -3464,7 +3464,29 @@ To change this setting, BEGIN_LINKdelete the Chrome d +@@ -3459,7 +3459,29 @@ To change this setting, BEGIN_LINKdelete the Chrome d %1$sGoogle Maps will open in Chrome. By continuing, you agree to the <LINK1>Google Terms of Service</LINK1>, and the <LINK2>Google Chrome and ChromeOS Additional Terms of Service</LINK2>. The <LINK3>Privacy Policy</LINK3> also applies.