From 8cafb5ce1027b6788654c4153ff4cfe9ac764bee Mon Sep 17 00:00:00 2001 From: Carmelo Messina Date: Tue, 3 Jun 2025 10:30:18 +0200 Subject: [PATCH] Allow DocumentPiP if PopupsAndRedirects are active: disables the possibility of verifying the activation of PIP in the device with document.pictureInPictureEnabled (#2059) --- ...entPiP-if-PopupsAndRedirects-are-active.patch | 16 +++++++++++++++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/build/patches/Allow-DocumentPiP-if-PopupsAndRedirects-are-active.patch b/build/patches/Allow-DocumentPiP-if-PopupsAndRedirects-are-active.patch index f266e29e..06413f06 100644 --- a/build/patches/Allow-DocumentPiP-if-PopupsAndRedirects-are-active.patch +++ b/build/patches/Allow-DocumentPiP-if-PopupsAndRedirects-are-active.patch @@ -3,12 +3,26 @@ Date: Mon, 7 Aug 2023 11:02:18 +0000 Subject: Allow DocumentPiP if PopupsAndRedirects are active Allow documentPiP api use only with content setting popup allowed +and disables the possibility of verifying the activation of PIP +in the device with document.pictureInPictureEnabled License: GPL-2.0-or-later - https://spdx.org/licenses/GPL-2.0-or-later.html --- + .../chromium/chrome/browser/media/PictureInPicture.java | 1 + .../picture_in_picture_controller_impl.cc | 7 +++++++ - 1 file changed, 7 insertions(+) + 2 files changed, 8 insertions(+) +diff --git a/chrome/android/java/src/org/chromium/chrome/browser/media/PictureInPicture.java b/chrome/android/java/src/org/chromium/chrome/browser/media/PictureInPicture.java +--- a/chrome/android/java/src/org/chromium/chrome/browser/media/PictureInPicture.java ++++ b/chrome/android/java/src/org/chromium/chrome/browser/media/PictureInPicture.java +@@ -27,6 +27,7 @@ public abstract class PictureInPicture { + * @return boolean true if Picture-In-Picture is enabled, otherwise false. + */ + public static boolean isEnabled(Context context) { ++ if ((true)) return true; + // Some versions of Android crash when the activity enters Picture-in-Picture + // immediately after it exits Picture-in-Picture. See b/143784148 + if (Build.VERSION.SDK_INT < Build.VERSION_CODES.R) { diff --git a/third_party/blink/renderer/modules/document_picture_in_picture/picture_in_picture_controller_impl.cc b/third_party/blink/renderer/modules/document_picture_in_picture/picture_in_picture_controller_impl.cc --- a/third_party/blink/renderer/modules/document_picture_in_picture/picture_in_picture_controller_impl.cc +++ b/third_party/blink/renderer/modules/document_picture_in_picture/picture_in_picture_controller_impl.cc