From f251a3d9c59dfa95d008c571bcb7ec1f6c080d69 Mon Sep 17 00:00:00 2001 From: 0xedward <14011954+0xedward@users.noreply.github.com> Date: Fri, 21 Jul 2023 15:00:55 -0400 Subject: [PATCH 1/6] Update references from Bromite to Cromite --- .github/ISSUE_TEMPLATE/bug_report.yml | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 1f211ea4..c7977f3c 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -1,13 +1,13 @@ name: Bug report -description: Create a Bromite bug report +description: Create a Cromite bug report body: - type: markdown attributes: value: | Welcome! Thanks for taking the time to submit a bug report. - If this is not a bug about the Bromite browser, or you are looking for a place to ask a question to the community, - then please use the [GitHub Discussions](https://github.com/bromite/bromite/discussions) instead. + If this is not a bug about the Cromite browser, or you are looking for a place to ask a question to the community, + then please use the [GitHub Discussions](https://github.com/uazo/cromite/discussions) instead. Make sure you have acknowledged and completed this template before submitting your issue. @@ -18,15 +18,15 @@ body: attributes: label: Preliminary checklist options: - - label: "I have read the [README](https://github.com/bromite/bromite/blob/master/README.md)." + - label: "I have read the [README](https://github.com/uazo/cromite/blob/master/README.md)." required: true - label: "I have searched the existing issues for my problem. This is a new ticket, NOT a duplicate or related to another open issue." required: true - - label: "I have read the [FAQs](https://github.com/bromite/bromite/blob/master/FAQ.md)." + - label: "I have read the [FAQs](https://github.com/uazo/cromite/blob/master/FAQ.md)." required: true - - label: "I have updated Bromite to the latest version. The bug is reproducible on this latest version." + - label: "I have updated Cromite to the latest version. The bug is reproducible on this latest version." required: true - - label: "This is a bug report about the Bromite browser; not the website nor F-Droid nor anything else." + - label: "This is a bug report about the Cromite browser; not the website nor F-Droid nor anything else." required: true - type: dropdown @@ -34,7 +34,7 @@ body: attributes: label: Can the bug be reproduced with corresponding Chromium version? description: | - Please pick the same version of Chromium as Bromite from here: https://github.com/bromite/chromium/releases + Please pick the same version of Chromium as Cromite If the bug is reproducible then it might be a configuration issue or an upstream bug. Upstream bugs can be reported on the [Chromium issue tracker](https://bugs.chromium.org/p/chromium/issues/list) and do not forget to read [Chromium project bug reporting guidelines](https://www.chromium.org/for-testers/bug-reporting-guidelines) first. @@ -47,10 +47,10 @@ body: required: true - type: input - id: bromite_version + id: cromite_version attributes: - label: Bromite version - description: What version of Bromite are you using? Please specify a single version e.g. `96.0.4664.1` not `latest`. If this is not the latest version then please update and retry before submitting this bug report. + label: Cromite version + description: What version of Cromite are you using? Please specify a single version e.g. `96.0.4664.1` not `latest`. If this is not the latest version then please update and retry before submitting this bug report. validations: required: true @@ -162,7 +162,7 @@ body: 2. Yes, I have attached the crash report dump that I downloaded from `chrome://crashes` 3. Yes, I have copy/pasted the crash dump placeholder: | - Drag the crash report dump here to attach it or paste the logcat dump individuated with `adb logcat | grep -E '( cr_|bromite|chromium)'`. + Drag the crash report dump here to attach it or paste the logcat dump individuated with `adb logcat | grep -E '( cr_|cromite|chromium)'`. validations: required: true From d4710fc69f765a34366d775a7be07db02d119d34 Mon Sep 17 00:00:00 2001 From: 0xedward <14011954+0xedward@users.noreply.github.com> Date: Fri, 21 Jul 2023 15:01:34 -0400 Subject: [PATCH 2/6] Add Android 13 to dropdown list for `android_version` --- .github/ISSUE_TEMPLATE/bug_report.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index c7977f3c..db4fb5c8 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -76,6 +76,7 @@ body: multiple: false description: What version of Android are you running? options: + - 13 - 12.1 - 12.0 - 11 From 659cfbc3f66b4cc111fd2a77515623e950fdcb42 Mon Sep 17 00:00:00 2001 From: 0xedward <14011954+0xedward@users.noreply.github.com> Date: Fri, 21 Jul 2023 15:02:45 -0400 Subject: [PATCH 3/6] Remove field for SystemWebView See https://github.com/uazo/cromite/issues/77#issuecomment-1645453577 --- .github/ISSUE_TEMPLATE/bug_report.yml | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index db4fb5c8..492582de 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -119,18 +119,6 @@ body: validations: required: true - - type: dropdown - id: is_system_webview - attributes: - label: Is this bug about the SystemWebView? - description: Please note that no support for System WebView installation is provided. - multiple: false - options: - - "Yes" - - "No" - validations: - required: true - - type: dropdown id: is_incognito attributes: From 7aa295041ef038537e98cae94fd39bcdadf53014 Mon Sep 17 00:00:00 2001 From: 0xedward <14011954+0xedward@users.noreply.github.com> Date: Fri, 21 Jul 2023 15:04:20 -0400 Subject: [PATCH 4/6] Update references from Bromite to Cromite --- .github/ISSUE_TEMPLATE/feature_request.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index a3dd75e0..282194e0 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -1,13 +1,13 @@ name: Feature request -description: Create a Bromite feature request +description: Create a Cromite feature request body: - type: markdown attributes: value: | Welcome! Thanks for taking time to submit a feature request. - If this is not a feature request about the Bromite browser, or you are looking for a place - to ask a question to the community then please use the [GitHub Discussions](https://github.com/bromite/bromite/discussions) instead. + If this is not a feature request about the Cromite browser, or you are looking for a place + to ask a question to the community then please use the [GitHub Discussions](https://github.com/uazo/cromite/discussions) instead. Make sure you have acknowledged and completed this template before submitting your issue. @@ -22,13 +22,13 @@ body: attributes: label: Preliminary checklist options: - - label: "I have read the [README](https://github.com/bromite/bromite/blob/master/README.md)" + - label: "I have read the [README](https://github.com/uazo/cromite/blob/master/README.md)" required: true - - label: "I have read the [FAQs](https://github.com/bromite/bromite/blob/master/FAQ.md)." + - label: "I have read the [FAQs](https://github.com/uazo/cromite/blob/master/FAQ.md)." required: true - - label: "I have searched [existing issues](https://github.com/bromite/bromite/issues) for my feature request. This is a new issue (NOT a duplicate) and is not related to another issue." + - label: "I have searched [existing issues](https://github.com/uazo/cromite/issues) for my feature request. This is a new issue (NOT a duplicate) and is not related to another issue." required: true - - label: "This is a feature request for the Bromite browser; not the website nor F-Droid nor anything else." + - label: "This is a feature request for the Cromite browser; not the website nor F-Droid nor anything else." required: true - type: dropdown From f7ed8e7a86bd4b48c244836aa006eb5651a1e8b5 Mon Sep 17 00:00:00 2001 From: Carmelo Messina Date: Sat, 22 Jul 2023 17:42:48 +0200 Subject: [PATCH 5/6] remove trailing spaces --- .github/ISSUE_TEMPLATE/bug_report.yml | 14 +++++++------- .github/ISSUE_TEMPLATE/feature_request.yml | 8 ++++---- 2 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 492582de..d08a03aa 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -5,14 +5,14 @@ body: attributes: value: | Welcome! Thanks for taking the time to submit a bug report. - + If this is not a bug about the Cromite browser, or you are looking for a place to ask a question to the community, then please use the [GitHub Discussions](https://github.com/uazo/cromite/discussions) instead. - + Make sure you have acknowledged and completed this template before submitting your issue. - + Please read it carefully: incorrect issues will be automatically closed and ignored. - + - type: checkboxes id: preliminary_checklist attributes: @@ -37,7 +37,7 @@ body: Please pick the same version of Chromium as Cromite If the bug is reproducible then it might be a configuration issue or an upstream bug. Upstream bugs can be reported on the [Chromium issue tracker](https://bugs.chromium.org/p/chromium/issues/list) and do not forget to read [Chromium project bug reporting guidelines](https://www.chromium.org/for-testers/bug-reporting-guidelines) first. - + If the bug is related to functionality that does not exist in Chromium then answer "No". multiple: false options: @@ -113,7 +113,7 @@ body: description: | These are the flags changed under `chrome://flags`. Report all the flags with non-default configuration (they will be blue-highlighted). - + If no flags are changed then write 'no flags changed'. placeholder: show-overdraw-feedback, enable-parallel-downloading validations: @@ -169,7 +169,7 @@ body: label: Steps to reproduce the bug description: | Explain how to cause the bug as clearly as possible. Bugs that are not reproducible cannot be investigated. - + Also, do not write "any website": please specify which URLs can be used to reproduce the issue. placeholder: | Steps to reproduce the bug (e.g.): diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index 282194e0..c0531738 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -5,14 +5,14 @@ body: attributes: value: | Welcome! Thanks for taking time to submit a feature request. - + If this is not a feature request about the Cromite browser, or you are looking for a place to ask a question to the community then please use the [GitHub Discussions](https://github.com/uazo/cromite/discussions) instead. - + Make sure you have acknowledged and completed this template before submitting your issue. - + Please read it carefully: incorrect issues will be automatically closed and ignored. - + Note: - Features unrelated to privacy will not be considered. - Do not ask "I would like feature X which is available in browser Y." From 60acd4460ee3e9af109bf49891094bcb8d4e4cd6 Mon Sep 17 00:00:00 2001 From: Carmelo Messina Date: Sat, 22 Jul 2023 17:44:59 +0200 Subject: [PATCH 6/6] add android 14 as suggested --- .github/ISSUE_TEMPLATE/bug_report.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index d08a03aa..9f1e503f 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -76,6 +76,7 @@ body: multiple: false description: What version of Android are you running? options: + - 14 - 13 - 12.1 - 12.0