Files
app_Settings/src/com/android/settings/users/AutoSyncDataPreferenceController.java
Chaohui Wang 9d8603568d Fix "Automatically sync app data" button state not changed
This issue is caused by mPreference is null.
(Not recovered when the fragment is recreated after configuration change.)

Mimic the PreferenceDialogFragmentCompat.getPreference() in AndroidX to
solve this issue.
https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:preference/preference/src/main/java/androidx/preference/PreferenceDialogFragmentCompat.java;l=176;drc=ca9feb3b73769089afbfd36b4d4a3d91239f9cd5

Ideally in the long term, we could use PreferenceDialogFragmentCompat
instead.

Fix: 218754949
Test: robotest & manual
Change-Id: I7fc8dd3b771aa45c91f915e25c8cc6c6afdd8d63
2022-03-29 12:32:23 +08:00

168 lines
6.6 KiB
Java

/*
* Copyright (C) 2016 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package com.android.settings.users;
import android.app.ActivityManager;
import android.app.Dialog;
import android.app.settings.SettingsEnums;
import android.content.ContentResolver;
import android.content.Context;
import android.content.DialogInterface;
import android.os.Bundle;
import android.os.Process;
import android.os.UserHandle;
import android.os.UserManager;
import android.util.Log;
import androidx.appcompat.app.AlertDialog;
import androidx.fragment.app.Fragment;
import androidx.preference.Preference;
import androidx.preference.PreferenceFragmentCompat;
import androidx.preference.SwitchPreference;
import com.android.settings.R;
import com.android.settings.core.PreferenceControllerMixin;
import com.android.settings.core.instrumentation.InstrumentedDialogFragment;
import com.android.settingslib.core.AbstractPreferenceController;
public class AutoSyncDataPreferenceController extends AbstractPreferenceController
implements PreferenceControllerMixin {
private static final String TAG = "AutoSyncDataController";
private static final String TAG_CONFIRM_AUTO_SYNC_CHANGE = "confirmAutoSyncChange";
private static final String KEY_AUTO_SYNC_ACCOUNT = "auto_sync_account_data";
protected final UserManager mUserManager;
private final PreferenceFragmentCompat mParentFragment;
protected UserHandle mUserHandle;
public AutoSyncDataPreferenceController(Context context, PreferenceFragmentCompat parent) {
super(context);
mUserManager = (UserManager) context.getSystemService(Context.USER_SERVICE);
mParentFragment = parent;
mUserHandle = Process.myUserHandle();
}
@Override
public void updateState(Preference preference) {
SwitchPreference switchPreference = (SwitchPreference) preference;
switchPreference.setChecked(ContentResolver.getMasterSyncAutomaticallyAsUser(
mUserHandle.getIdentifier()));
}
@Override
public boolean handlePreferenceTreeClick(Preference preference) {
if (getPreferenceKey().equals(preference.getKey())) {
SwitchPreference switchPreference = (SwitchPreference) preference;
boolean checked = switchPreference.isChecked();
switchPreference.setChecked(!checked);
if (ActivityManager.isUserAMonkey()) {
Log.d(TAG, "ignoring monkey's attempt to flip sync state");
} else {
ConfirmAutoSyncChangeFragment
.newInstance(checked, mUserHandle.getIdentifier(), getPreferenceKey())
.show(mParentFragment);
}
return true;
}
return false;
}
@Override
public boolean isAvailable() {
return !mUserManager.isManagedProfile()
&& (mUserManager.isRestrictedProfile()
|| mUserManager.getProfiles(UserHandle.myUserId()).size() == 1);
}
@Override
public String getPreferenceKey() {
return KEY_AUTO_SYNC_ACCOUNT;
}
/**
* Dialog to inform user about changing auto-sync setting
*/
public static class ConfirmAutoSyncChangeFragment extends InstrumentedDialogFragment implements
DialogInterface.OnClickListener {
private static final String ARG_ENABLING = "enabling";
private static final String ARG_USER_ID = "userId";
private static final String ARG_KEY = "key";
static ConfirmAutoSyncChangeFragment newInstance(boolean enabling, int userId, String key) {
ConfirmAutoSyncChangeFragment dialogFragment = new ConfirmAutoSyncChangeFragment();
Bundle arguments = new Bundle();
arguments.putBoolean(ARG_ENABLING, enabling);
arguments.putInt(ARG_USER_ID, userId);
arguments.putString(ARG_KEY, key);
dialogFragment.setArguments(arguments);
return dialogFragment;
}
void show(PreferenceFragmentCompat parent) {
if (!parent.isAdded()) {
return;
}
setTargetFragment(parent, 0);
show(parent.getParentFragmentManager(), TAG_CONFIRM_AUTO_SYNC_CHANGE);
}
@Override
public Dialog onCreateDialog(Bundle savedInstanceState) {
final Context context = getActivity();
final AlertDialog.Builder builder = new AlertDialog.Builder(context);
if (!requireArguments().getBoolean(ARG_ENABLING)) {
builder.setTitle(R.string.data_usage_auto_sync_off_dialog_title);
builder.setMessage(R.string.data_usage_auto_sync_off_dialog);
} else {
builder.setTitle(R.string.data_usage_auto_sync_on_dialog_title);
builder.setMessage(R.string.data_usage_auto_sync_on_dialog);
}
builder.setPositiveButton(android.R.string.ok, this);
builder.setNegativeButton(android.R.string.cancel, null);
return builder.create();
}
@Override
public int getMetricsCategory() {
return SettingsEnums.DIALOG_CONFIRM_AUTO_SYNC_CHANGE;
}
@Override
public void onClick(DialogInterface dialog, int which) {
if (which == DialogInterface.BUTTON_POSITIVE) {
Bundle arguments = requireArguments();
boolean enabling = arguments.getBoolean(ARG_ENABLING);
ContentResolver.setMasterSyncAutomaticallyAsUser(enabling,
arguments.getInt(ARG_USER_ID));
Fragment targetFragment = getTargetFragment();
if (targetFragment instanceof PreferenceFragmentCompat) {
Preference preference =
((PreferenceFragmentCompat) targetFragment).findPreference(
arguments.getString(ARG_KEY));
if (preference instanceof SwitchPreference) {
((SwitchPreference) preference).setChecked(enabling);
}
}
}
}
}
}