b61f945e8e
The LayoutPreference calls super.onBindPreview, which enables all children views. This is usually fine because a Preference object has just one click target. But the LayoutPreference can hold multiple click targets so we should not force enable everything during every single bind. To fix this, we don't call super.onBind, and manually wire up onClickListener and selectable/focusable state. Everything else from super.onBind is useless to this preference type. Change-Id: Ibb89f1be399311b9ee053733a050f04be6aa85e8 Fix: 37452204 Fix: 37538936 Fix: 35633637 Test: make RunSettingsRoboTests
96 lines
3.2 KiB
Java
96 lines
3.2 KiB
Java
/*
|
|
* Copyright (C) 2015 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package com.android.settings.applications;
|
|
|
|
import android.content.Context;
|
|
import android.content.res.TypedArray;
|
|
import android.support.annotation.VisibleForTesting;
|
|
import android.support.v7.preference.Preference;
|
|
import android.support.v7.preference.PreferenceViewHolder;
|
|
import android.util.AttributeSet;
|
|
import android.view.LayoutInflater;
|
|
import android.view.View;
|
|
import android.view.ViewGroup;
|
|
import android.widget.FrameLayout;
|
|
|
|
import com.android.settings.R;
|
|
import com.android.settings.Utils;
|
|
|
|
public class LayoutPreference extends Preference {
|
|
|
|
private final View.OnClickListener mClickListener = v -> performClick(v);
|
|
|
|
@VisibleForTesting
|
|
View mRootView;
|
|
|
|
public LayoutPreference(Context context, AttributeSet attrs) {
|
|
super(context, attrs);
|
|
final TypedArray a = context.obtainStyledAttributes(
|
|
attrs, com.android.internal.R.styleable.Preference, 0, 0);
|
|
int layoutResource = a.getResourceId(com.android.internal.R.styleable.Preference_layout,
|
|
0);
|
|
if (layoutResource == 0) {
|
|
throw new IllegalArgumentException("LayoutPreference requires a layout to be defined");
|
|
}
|
|
// Need to create view now so that findViewById can be called immediately.
|
|
final View view = LayoutInflater.from(getContext())
|
|
.inflate(layoutResource, null, false);
|
|
setView(view);
|
|
}
|
|
|
|
public LayoutPreference(Context context, int resource) {
|
|
this(context, LayoutInflater.from(context).inflate(resource, null, false));
|
|
}
|
|
|
|
public LayoutPreference(Context context, View view) {
|
|
super(context);
|
|
setView(view);
|
|
}
|
|
|
|
private void setView(View view) {
|
|
setLayoutResource(R.layout.layout_preference_frame);
|
|
final ViewGroup allDetails = view.findViewById(R.id.all_details);
|
|
if (allDetails != null) {
|
|
Utils.forceCustomPadding(allDetails, true /* additive padding */);
|
|
}
|
|
mRootView = view;
|
|
setShouldDisableView(false);
|
|
}
|
|
|
|
@Override
|
|
public void onBindViewHolder(PreferenceViewHolder holder) {
|
|
holder.itemView.setOnClickListener(mClickListener);
|
|
|
|
final boolean selectable = isSelectable();
|
|
holder.itemView.setFocusable(selectable);
|
|
holder.itemView.setClickable(selectable);
|
|
|
|
FrameLayout layout = (FrameLayout) holder.itemView;
|
|
layout.removeAllViews();
|
|
ViewGroup parent = (ViewGroup) mRootView.getParent();
|
|
if (parent != null) {
|
|
parent.removeView(mRootView);
|
|
}
|
|
layout.addView(mRootView);
|
|
}
|
|
|
|
public View findViewById(int id) {
|
|
return mRootView.findViewById(id);
|
|
}
|
|
|
|
}
|