4f87dd4b56
When ring volume is separated from notification, a new xml preferece and
controller is needed for it, so that the settings search can show/hide
the slice correctly.
1. Use a separate preference and controller for ring volume (vs ring &
notification combined)
2. Notification slice in settings no longer grays out when ringer mode
is set to mute or vibrate.
3. Introduce an abstract RingerModeAffected preference controller class
to factor out duplicate code among ring, notification, and separate-ring
controller classes.
Bug: b/259084354
Test: make ROBOTEST_FILTER=RingVolumePreferenceControllerTest
RunSettingsRoboTests -j40
make ROBOTEST_FILTER=SeparateRingVolumePreferenceControllerTest
RunSettingsRoboTests -j40
make ROBOTEST_FILTER=NotificationVolumePreferenceControllerTest
RunSettingsRoboTests -j40
make ROBOTEST_FILTER=VolumePanelTest RunSettingsRoboTests -j40
make
ROBOTEST_FILTER=RingerModeAffectedVolumePreferenceControllerTest -j40
Known Issue:
1. When streams are separate and ring volume set to mute/vibrate,
notification is set to zero, but not disabled. So it can be turned on
by user (and in settings the icon will stay mute/vibrate instead of
changing to the normal notification icon).
2. In the above scenario after notification is unmuted in settings,
the notification icon continues to stay vibrate/mute -- should change
to the normal notification icon.
Note: This feature is controlled using a boolean DeviceConfig flag:
systemui/"volume_separate_ring". The default value is 'false', which is
meant to keep the experience the same as before. It will be set to
'true' for teamfood and dogfood. Eventually the flag will be removed and
the code in the 'true' branch will prevail.
Change-Id: Ibec871eafeef4081e96c5e0dd04535565d50a077
108 lines
3.6 KiB
Java
108 lines
3.6 KiB
Java
/*
|
|
* Copyright (C) 2022 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package com.android.settings.notification;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
|
|
import static org.mockito.Mockito.spy;
|
|
import static org.mockito.Mockito.when;
|
|
|
|
import android.app.NotificationManager;
|
|
import android.content.ComponentName;
|
|
import android.content.Context;
|
|
import android.content.res.Resources;
|
|
import android.media.AudioManager;
|
|
import android.os.Vibrator;
|
|
import android.telephony.TelephonyManager;
|
|
|
|
import com.android.settings.testutils.shadow.ShadowDeviceConfig;
|
|
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.mockito.Mock;
|
|
import org.mockito.MockitoAnnotations;
|
|
import org.robolectric.RobolectricTestRunner;
|
|
import org.robolectric.RuntimeEnvironment;
|
|
import org.robolectric.annotation.Config;
|
|
import org.robolectric.shadows.ShadowApplication;
|
|
|
|
@RunWith(RobolectricTestRunner.class)
|
|
@Config(shadows = {ShadowDeviceConfig.class})
|
|
public class SeparateRingVolumePreferenceControllerTest {
|
|
|
|
@Mock
|
|
private AudioHelper mHelper;
|
|
@Mock
|
|
private TelephonyManager mTelephonyManager;
|
|
@Mock
|
|
private AudioManager mAudioManager;
|
|
@Mock
|
|
private Vibrator mVibrator;
|
|
@Mock
|
|
private NotificationManager mNotificationManager;
|
|
@Mock
|
|
private ComponentName mSuppressor;
|
|
@Mock
|
|
private Resources mResources;
|
|
|
|
private Context mContext;
|
|
|
|
private SeparateRingVolumePreferenceController mController;
|
|
|
|
@Before
|
|
public void setUp() {
|
|
MockitoAnnotations.initMocks(this);
|
|
ShadowApplication shadowContext = ShadowApplication.getInstance();
|
|
shadowContext.setSystemService(Context.TELEPHONY_SERVICE, mTelephonyManager);
|
|
shadowContext.setSystemService(Context.AUDIO_SERVICE, mAudioManager);
|
|
shadowContext.setSystemService(Context.VIBRATOR_SERVICE, mVibrator);
|
|
shadowContext.setSystemService(Context.NOTIFICATION_SERVICE, mNotificationManager);
|
|
mContext = spy(RuntimeEnvironment.application);
|
|
when(mNotificationManager.getEffectsSuppressor()).thenReturn(mSuppressor);
|
|
when(mContext.getResources()).thenReturn(mResources);
|
|
mController = new SeparateRingVolumePreferenceController(mContext);
|
|
mController.setAudioHelper(mHelper);
|
|
}
|
|
|
|
@Test
|
|
public void isAvailable_ringNotificationAliased_shouldReturnFalse() {
|
|
when(mHelper.isSingleVolume()).thenReturn(true);
|
|
when(mTelephonyManager.isVoiceCapable()).thenReturn(true);
|
|
|
|
assertThat(mController.isAvailable()).isFalse();
|
|
}
|
|
|
|
@Test
|
|
public void getAudioStream_shouldReturnRing() {
|
|
assertThat(mController.getAudioStream()).isEqualTo(AudioManager.STREAM_RING);
|
|
}
|
|
|
|
@Test
|
|
public void isSliceableCorrectKey_returnsTrue() {
|
|
final SeparateRingVolumePreferenceController controller =
|
|
new SeparateRingVolumePreferenceController(mContext);
|
|
assertThat(controller.isSliceable()).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void isPublicSlice_returnTrue() {
|
|
assertThat(mController.isPublicSlice()).isTrue();
|
|
}
|
|
|
|
}
|