1. When condition is inserted, only scroll to top when previous position is at the top. 2. Clean condition status after it is removed. So the next time you insert a condition view, it will always be collapsed. Bug: 33839780 Bug: 34115341 Test: make -j40 RunSettingsRoboTests Change-Id: I7f48524917c3119ec24b2f67ba506f381573a391
93 lines
3.4 KiB
Java
93 lines
3.4 KiB
Java
/*
|
|
* Copyright (C) 2017 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package com.android.settings.dashboard;
|
|
|
|
import android.app.Activity;
|
|
|
|
import android.support.v7.widget.LinearLayoutManager;
|
|
import com.android.settings.SettingsRobolectricTestRunner;
|
|
import com.android.settings.TestConfig;
|
|
import com.android.settings.dashboard.conditional.ConditionManager;
|
|
import com.android.settings.dashboard.conditional.FocusRecyclerView;
|
|
import com.android.settingslib.drawer.CategoryKey;
|
|
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.mockito.Mock;
|
|
import org.mockito.MockitoAnnotations;
|
|
import org.robolectric.annotation.Config;
|
|
import org.robolectric.util.ReflectionHelpers;
|
|
|
|
import static org.mockito.Mockito.doReturn;
|
|
import static org.mockito.Mockito.mock;
|
|
import static org.mockito.Mockito.never;
|
|
import static org.mockito.Mockito.spy;
|
|
import static org.mockito.Mockito.verify;
|
|
import static org.mockito.Mockito.when;
|
|
|
|
@RunWith(SettingsRobolectricTestRunner.class)
|
|
@Config(manifest = TestConfig.MANIFEST_PATH, sdk = TestConfig.SDK_VERSION)
|
|
public class DashboardSummaryTest {
|
|
|
|
@Mock
|
|
private DashboardAdapter mAdapter;
|
|
@Mock
|
|
private DashboardFeatureProvider mDashboardFeatureProvider;
|
|
@Mock
|
|
private FocusRecyclerView mDashboard;
|
|
@Mock
|
|
private LinearLayoutManager mLayoutManager;
|
|
@Mock
|
|
private ConditionManager mConditionManager;
|
|
|
|
private DashboardSummary mSummary;
|
|
|
|
@Before
|
|
public void setUp() {
|
|
MockitoAnnotations.initMocks(this);
|
|
mSummary = spy(new DashboardSummary());
|
|
ReflectionHelpers.setField(mSummary, "mAdapter", mAdapter);
|
|
ReflectionHelpers.setField(mSummary, "mDashboardFeatureProvider",
|
|
mDashboardFeatureProvider);
|
|
ReflectionHelpers.setField(mSummary, "mDashboard", mDashboard);
|
|
ReflectionHelpers.setField(mSummary, "mLayoutManager", mLayoutManager);
|
|
ReflectionHelpers.setField(mSummary, "mConditionManager", mConditionManager);
|
|
}
|
|
|
|
@Test
|
|
public void updateCategoryAndSuggestion_shouldGetCategoryFromFeatureProvider() {
|
|
doReturn(mock(Activity.class)).when(mSummary).getActivity();
|
|
when(mDashboardFeatureProvider.isEnabled()).thenReturn(true);
|
|
mSummary.updateCategoryAndSuggestion(null);
|
|
verify(mDashboardFeatureProvider).getTilesForCategory(CategoryKey.CATEGORY_HOMEPAGE);
|
|
}
|
|
|
|
@Test
|
|
public void onConditionChanged_PositionAtTop_ScrollToTop() {
|
|
when(mLayoutManager.findFirstCompletelyVisibleItemPosition()).thenReturn(1);
|
|
mSummary.onConditionsChanged();
|
|
verify(mDashboard).scrollToPosition(0);
|
|
}
|
|
|
|
@Test
|
|
public void onConditionChanged_PositionNotTop_RemainPosition() {
|
|
when(mLayoutManager.findFirstCompletelyVisibleItemPosition()).thenReturn(2);
|
|
mSummary.onConditionsChanged();
|
|
verify(mDashboard, never()).scrollToPosition(0);
|
|
}
|
|
} |