Root cause: There is a bunch of different logic of preferences in ToggleAutoclickPreferenceFragment. It’s hard to implement new features and hard to maintain and hard to be testable. Solution: Move out logic of ToggleAutoclickPreferenceFragment into controllers to reduce the complexity of the relationship between preference and fragment. Bug: 197695932 Test: make RunSettingsRoboTests ROBOTEST_FILTER=com.android.settings.accessibility Change-Id: I5db18d5a0c577ad67d15c2d0169a36a67e9f13db
222 lines
8.7 KiB
Java
222 lines
8.7 KiB
Java
/*
|
|
* Copyright (C) 2021 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package com.android.settings.accessibility;
|
|
|
|
import static android.content.Context.MODE_PRIVATE;
|
|
|
|
import static com.android.settings.accessibility.AutoclickUtils.KEY_CUSTOM_DELAY_VALUE;
|
|
import static com.android.settings.accessibility.AutoclickUtils.KEY_DELAY_MODE;
|
|
import static com.android.settings.core.BasePreferenceController.AVAILABLE;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
|
|
import static org.mockito.ArgumentMatchers.anyInt;
|
|
import static org.mockito.ArgumentMatchers.anyString;
|
|
import static org.mockito.Mockito.doReturn;
|
|
import static org.mockito.Mockito.mock;
|
|
import static org.mockito.Mockito.verify;
|
|
import static org.robolectric.Shadows.shadowOf;
|
|
|
|
import android.content.Context;
|
|
import android.content.SharedPreferences;
|
|
import android.provider.Settings;
|
|
import android.widget.ImageView;
|
|
import android.widget.SeekBar;
|
|
import android.widget.TextView;
|
|
|
|
import androidx.preference.PreferenceScreen;
|
|
import androidx.test.core.app.ApplicationProvider;
|
|
|
|
import com.android.settings.R;
|
|
import com.android.settingslib.widget.LayoutPreference;
|
|
|
|
import org.junit.Before;
|
|
import org.junit.Rule;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.mockito.Mock;
|
|
import org.mockito.Spy;
|
|
import org.mockito.junit.MockitoJUnit;
|
|
import org.mockito.junit.MockitoRule;
|
|
import org.robolectric.RobolectricTestRunner;
|
|
|
|
/** Tests for {@link ToggleAutoclickCustomSeekbarController}. */
|
|
@RunWith(RobolectricTestRunner.class)
|
|
public class ToggleAutoclickCustomSeekbarControllerTest {
|
|
|
|
private static final String KEY_CUSTOM_SEEKBAR = "autoclick_custom_seekbar";
|
|
|
|
@Rule
|
|
public final MockitoRule mMockitoRule = MockitoJUnit.rule();
|
|
@Mock
|
|
private PreferenceScreen mScreen;
|
|
@Mock
|
|
private LayoutPreference mLayoutPreference;
|
|
@Spy
|
|
private Context mContext = ApplicationProvider.getApplicationContext();
|
|
private SharedPreferences mSharedPreferences;
|
|
private TextView mDelayLabel;
|
|
private ImageView mShorter;
|
|
private ImageView mLonger;
|
|
private SeekBar mSeekBar;
|
|
private ToggleAutoclickCustomSeekbarController mController;
|
|
|
|
@Before
|
|
public void setUp() {
|
|
mSharedPreferences = mContext.getSharedPreferences(mContext.getPackageName(), MODE_PRIVATE);
|
|
mDelayLabel = new TextView(mContext);
|
|
mShorter = new ImageView(mContext);
|
|
mLonger = new ImageView(mContext);
|
|
mSeekBar = new SeekBar(mContext);
|
|
mController = new ToggleAutoclickCustomSeekbarController(mContext, KEY_CUSTOM_SEEKBAR);
|
|
doReturn(mLayoutPreference).when(mScreen).findPreference(KEY_CUSTOM_SEEKBAR);
|
|
doReturn(mSeekBar).when(mLayoutPreference).findViewById(R.id.autoclick_delay);
|
|
doReturn(mDelayLabel).when(mLayoutPreference).findViewById(R.id.current_label);
|
|
doReturn(mShorter).when(mLayoutPreference).findViewById(R.id.shorter);
|
|
doReturn(mLonger).when(mLayoutPreference).findViewById(R.id.longer);
|
|
}
|
|
|
|
@Test
|
|
public void getAvailabilityStatus_available() {
|
|
assertThat(mController.getAvailabilityStatus()).isEqualTo(AVAILABLE);
|
|
}
|
|
|
|
@Test
|
|
public void displayPreference_initSeekBar() {
|
|
mSharedPreferences.edit().putInt(KEY_CUSTOM_DELAY_VALUE, 700).apply();
|
|
|
|
mController.onStart();
|
|
mController.displayPreference(mScreen);
|
|
mController.onStop();
|
|
final SeekBar.OnSeekBarChangeListener mListener =
|
|
shadowOf(mSeekBar).getOnSeekBarChangeListener();
|
|
|
|
assertThat(mSeekBar.getMax()).isEqualTo(8);
|
|
assertThat(mSeekBar.getProgress()).isEqualTo(5);
|
|
assertThat(mListener).isNotNull();
|
|
}
|
|
|
|
@Test
|
|
public void displayPreference_initDelayLabel() {
|
|
mSharedPreferences.edit().putInt(KEY_CUSTOM_DELAY_VALUE, 700).apply();
|
|
|
|
mController.onStart();
|
|
mController.displayPreference(mScreen);
|
|
mController.onStop();
|
|
|
|
assertThat(mDelayLabel.getText()).isEqualTo("0.7 seconds");
|
|
}
|
|
|
|
@Test
|
|
public void onSharedPreferenceChanged_delayMode_updateCustomDelayValue() {
|
|
mSharedPreferences.edit().putInt(KEY_CUSTOM_DELAY_VALUE, 700).apply();
|
|
|
|
mController.displayPreference(mScreen);
|
|
mController.onSharedPreferenceChanged(mSharedPreferences, KEY_DELAY_MODE);
|
|
final int actualDelayValue =
|
|
Settings.Secure.getInt(mContext.getContentResolver(),
|
|
Settings.Secure.ACCESSIBILITY_AUTOCLICK_DELAY, /* def= */ 0);
|
|
final int actualCustomDelayValue =
|
|
mSharedPreferences.getInt(KEY_CUSTOM_DELAY_VALUE, /* defValue= */ 0);
|
|
|
|
assertThat(mDelayLabel.getText()).isEqualTo("0.7 seconds");
|
|
assertThat(mSeekBar.getProgress()).isEqualTo(5);
|
|
assertThat(actualDelayValue).isEqualTo(700);
|
|
assertThat(actualCustomDelayValue).isEqualTo(700);
|
|
}
|
|
|
|
@Test
|
|
public void onSeekBarProgressChanged_updateCustomDelayValue() {
|
|
mSharedPreferences.edit().putInt(KEY_CUSTOM_DELAY_VALUE, 700).apply();
|
|
|
|
mController.displayPreference(mScreen);
|
|
mController.mSeekBarChangeListener.onProgressChanged(mock(SeekBar.class),
|
|
/* value= */ 8,
|
|
true);
|
|
final int actualDelayValue =
|
|
Settings.Secure.getInt(mContext.getContentResolver(),
|
|
Settings.Secure.ACCESSIBILITY_AUTOCLICK_DELAY, /* def= */ 0);
|
|
final int actualCustomDelayValue =
|
|
mSharedPreferences.getInt(KEY_CUSTOM_DELAY_VALUE, /* defValue= */ 0);
|
|
|
|
assertThat(mDelayLabel.getText()).isEqualTo("1 second");
|
|
assertThat(mSeekBar.getProgress()).isEqualTo(8);
|
|
assertThat(actualDelayValue).isEqualTo(1000);
|
|
assertThat(actualCustomDelayValue).isEqualTo(1000);
|
|
}
|
|
|
|
@Test
|
|
public void onShorterClicked_updateCustomDelayValue() {
|
|
mSharedPreferences.edit().putInt(KEY_CUSTOM_DELAY_VALUE, 700).apply();
|
|
|
|
mController.displayPreference(mScreen);
|
|
mShorter.callOnClick();
|
|
final int actualDelayValue =
|
|
Settings.Secure.getInt(mContext.getContentResolver(),
|
|
Settings.Secure.ACCESSIBILITY_AUTOCLICK_DELAY, /* def= */ 0);
|
|
final int actualCustomDelayValue =
|
|
mSharedPreferences.getInt(KEY_CUSTOM_DELAY_VALUE, /* defValue= */ 0);
|
|
|
|
assertThat(mSeekBar.getProgress()).isEqualTo(4);
|
|
assertThat(mDelayLabel.getText()).isEqualTo("0.6 seconds");
|
|
assertThat(actualDelayValue).isEqualTo(600);
|
|
assertThat(actualCustomDelayValue).isEqualTo(600);
|
|
}
|
|
|
|
@Test
|
|
public void onLongerClicked_updateCustomDelayValue() {
|
|
mSharedPreferences.edit().putInt(KEY_CUSTOM_DELAY_VALUE, 700).apply();
|
|
|
|
mController.displayPreference(mScreen);
|
|
mLonger.callOnClick();
|
|
final int actualDelayValue =
|
|
Settings.Secure.getInt(mContext.getContentResolver(),
|
|
Settings.Secure.ACCESSIBILITY_AUTOCLICK_DELAY, /* def= */ 0);
|
|
final int actualCustomDelayValue =
|
|
mSharedPreferences.getInt(KEY_CUSTOM_DELAY_VALUE, /* defValue= */ 0);
|
|
|
|
assertThat(mSeekBar.getProgress()).isEqualTo(6);
|
|
assertThat(mDelayLabel.getText()).isEqualTo("0.8 seconds");
|
|
assertThat(actualDelayValue).isEqualTo(800);
|
|
assertThat(actualCustomDelayValue).isEqualTo(800);
|
|
}
|
|
|
|
@Test
|
|
public void onStart_registerOnSharedPreferenceChangeListener() {
|
|
final SharedPreferences prefs = mock(SharedPreferences.class);
|
|
doReturn(prefs).when(mContext).getSharedPreferences(anyString(), anyInt());
|
|
final ToggleAutoclickCustomSeekbarController controller =
|
|
new ToggleAutoclickCustomSeekbarController(mContext, KEY_CUSTOM_SEEKBAR);
|
|
|
|
controller.onStart();
|
|
|
|
verify(prefs).registerOnSharedPreferenceChangeListener(controller);
|
|
}
|
|
|
|
@Test
|
|
public void onStop_unregisterOnSharedPreferenceChangeListener() {
|
|
final SharedPreferences prefs = mock(SharedPreferences.class);
|
|
doReturn(prefs).when(mContext).getSharedPreferences(anyString(), anyInt());
|
|
final ToggleAutoclickCustomSeekbarController controller =
|
|
new ToggleAutoclickCustomSeekbarController(mContext, KEY_CUSTOM_SEEKBAR);
|
|
|
|
controller.onStop();
|
|
|
|
verify(prefs).unregisterOnSharedPreferenceChangeListener(controller);
|
|
}
|
|
}
|