Replace the build-time boolean resource with a run time device config flag that signals whether the ring notification slider should be displayed or not Bug: b/38477228 Test: make DEBUG_ROBOLECTRIC=1 ROBOTEST_FILTER=NotificationVolumePreferenceControllerTest RunSettingsRoboTests -j40 make DEBUG_ROBOLECTRIC=1 ROBOTEST_FILTER=RingVolumePreferenceControllerTest RunSettingsRoboTests -j40 Change-Id: I8b9a2cbd5af7fa1bba56ff9ba62771d677d4a932
258 lines
9.9 KiB
Java
258 lines
9.9 KiB
Java
/*
|
|
* Copyright (C) 2016 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package com.android.settings.notification;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
|
|
import static org.mockito.Mockito.mock;
|
|
import static org.mockito.Mockito.spy;
|
|
import static org.mockito.Mockito.when;
|
|
|
|
import android.content.Context;
|
|
import android.content.res.Resources;
|
|
import android.media.AudioManager;
|
|
import android.os.Vibrator;
|
|
import android.provider.DeviceConfig;
|
|
import android.service.notification.NotificationListenerService;
|
|
import android.telephony.TelephonyManager;
|
|
|
|
import androidx.preference.PreferenceManager;
|
|
import androidx.preference.PreferenceScreen;
|
|
import androidx.test.core.app.ApplicationProvider;
|
|
|
|
import com.android.internal.config.sysui.SystemUiDeviceConfigFlags;
|
|
import com.android.settings.core.BasePreferenceController;
|
|
import com.android.settings.testutils.shadow.ShadowDeviceConfig;
|
|
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
import org.mockito.Mock;
|
|
import org.mockito.MockitoAnnotations;
|
|
import org.robolectric.RobolectricTestRunner;
|
|
import org.robolectric.RuntimeEnvironment;
|
|
import org.robolectric.Shadows;
|
|
import org.robolectric.annotation.Config;
|
|
|
|
@RunWith(RobolectricTestRunner.class)
|
|
@Config(shadows = {ShadowDeviceConfig.class})
|
|
public class NotificationVolumePreferenceControllerTest {
|
|
@Mock
|
|
private AudioHelper mHelper;
|
|
@Mock
|
|
private TelephonyManager mTelephonyManager;
|
|
@Mock
|
|
private AudioManager mAudioManager;
|
|
@Mock
|
|
private Vibrator mVibrator;
|
|
@Mock
|
|
private Resources mResources;
|
|
@Mock
|
|
private PreferenceManager mPreferenceManager;
|
|
|
|
private static final String READ_DEVICE_CONFIG_PERMISSION =
|
|
"android.permission.READ_DEVICE_CONFIG";
|
|
|
|
private Context mContext;
|
|
private NotificationVolumePreferenceController mController;
|
|
|
|
@Before
|
|
public void setUp() {
|
|
MockitoAnnotations.initMocks(this);
|
|
mContext = spy(RuntimeEnvironment.application);
|
|
when(mContext.getSystemService(Context.TELEPHONY_SERVICE)).thenReturn(mTelephonyManager);
|
|
when(mContext.getSystemService(Context.AUDIO_SERVICE)).thenReturn(mAudioManager);
|
|
when(mContext.getSystemService(Context.VIBRATOR_SERVICE)).thenReturn(mVibrator);
|
|
when(mContext.getResources()).thenReturn(mResources);
|
|
|
|
mController = new NotificationVolumePreferenceController(mContext);
|
|
mController.setAudioHelper(mHelper);
|
|
}
|
|
|
|
@Test
|
|
@Config(qualifiers = "mcc999")
|
|
public void isAvailable_whenNotVisible_shouldReturnFalse() {
|
|
assertThat(mController.isAvailable()).isFalse();
|
|
}
|
|
|
|
@Test
|
|
public void isAvailable_singleVolume_shouldReturnFalse() {
|
|
when(mHelper.isSingleVolume()).thenReturn(true);
|
|
when(mTelephonyManager.isVoiceCapable()).thenReturn(false);
|
|
|
|
assertThat(mController.isAvailable()).isFalse();
|
|
}
|
|
|
|
@Test
|
|
public void isAvailable_voiceCapable_aliasedWithRing_shouldReturnFalse() {
|
|
when(mResources.getBoolean(
|
|
com.android.settings.R.bool.config_show_notification_volume)).thenReturn(true);
|
|
|
|
DeviceConfig.setProperty(DeviceConfig.NAMESPACE_SYSTEMUI,
|
|
SystemUiDeviceConfigFlags.VOLUME_SEPARATE_NOTIFICATION, "false", false);
|
|
|
|
NotificationVolumePreferenceController controller =
|
|
new NotificationVolumePreferenceController(mContext);
|
|
when(mHelper.isSingleVolume()).thenReturn(false);
|
|
when(mTelephonyManager.isVoiceCapable()).thenReturn(true);
|
|
|
|
assertThat(controller.isAvailable()).isFalse();
|
|
}
|
|
|
|
/**
|
|
* With the introduction of ring-notification volume separation, voice-capable devices could now
|
|
* display the notification volume slider.
|
|
*/
|
|
@Test
|
|
public void isAvailable_voiceCapable_separatedFromRing_shouldReturnTrue() {
|
|
when(mResources.getBoolean(
|
|
com.android.settings.R.bool.config_show_notification_volume)).thenReturn(true);
|
|
|
|
DeviceConfig.setProperty(DeviceConfig.NAMESPACE_SYSTEMUI,
|
|
SystemUiDeviceConfigFlags.VOLUME_SEPARATE_NOTIFICATION, "true", false);
|
|
|
|
NotificationVolumePreferenceController controller =
|
|
new NotificationVolumePreferenceController(mContext);
|
|
|
|
when(mHelper.isSingleVolume()).thenReturn(false);
|
|
when(mTelephonyManager.isVoiceCapable()).thenReturn(true);
|
|
|
|
assertThat(controller.isAvailable()).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void isAvailable_notShowNotificationVolume_shouldReturnFalse() {
|
|
when(mResources.getBoolean(
|
|
com.android.settings.R.bool.config_show_notification_volume)).thenReturn(false);
|
|
|
|
assertThat(mController.isAvailable()).isFalse();
|
|
}
|
|
|
|
@Test
|
|
public void isAvailable_notSingleVolume_notVoiceCapable_shouldReturnTrue() {
|
|
when(mResources.getBoolean(
|
|
com.android.settings.R.bool.config_show_notification_volume)).thenReturn(true);
|
|
when(mHelper.isSingleVolume()).thenReturn(false);
|
|
when(mTelephonyManager.isVoiceCapable()).thenReturn(false);
|
|
|
|
assertThat(mController.isAvailable()).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void getAudioStream_shouldReturnNotification() {
|
|
assertThat(mController.getAudioStream()).isEqualTo(AudioManager.STREAM_NOTIFICATION);
|
|
}
|
|
|
|
@Test
|
|
public void isSliceableCorrectKey_returnsTrue() {
|
|
final NotificationVolumePreferenceController controller =
|
|
new NotificationVolumePreferenceController(mContext);
|
|
assertThat(controller.isSliceable()).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void isPublicSlice_returnTrue() {
|
|
assertThat(mController.isPublicSlice()).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void setHintsRing_DoesNotMatch() {
|
|
assertThat(mController.hintsMatch(
|
|
NotificationListenerService.HINT_HOST_DISABLE_CALL_EFFECTS)).isFalse();
|
|
}
|
|
|
|
@Test
|
|
public void setHintsAll_Matches() {
|
|
assertThat(mController.hintsMatch(NotificationListenerService.HINT_HOST_DISABLE_EFFECTS))
|
|
.isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void setHintNotification_Matches() {
|
|
assertThat(mController
|
|
.hintsMatch(NotificationListenerService.HINT_HOST_DISABLE_NOTIFICATION_EFFECTS))
|
|
.isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void enableSeparateNotificationConfig_controllerBecomesAvailable() {
|
|
PreferenceScreen screen = spy(new PreferenceScreen(mContext, null));
|
|
VolumeSeekBarPreference volumeSeekBarPreference = mock(VolumeSeekBarPreference.class);
|
|
when(screen.getPreferenceManager()).thenReturn(mPreferenceManager);
|
|
when(screen.getContext()).thenReturn(mContext);
|
|
when(mResources.getBoolean(
|
|
com.android.settings.R.bool.config_show_notification_volume)).thenReturn(true);
|
|
// block the alternative condition to enable controller
|
|
when(mTelephonyManager.isVoiceCapable()).thenReturn(true);
|
|
|
|
DeviceConfig.setProperty(DeviceConfig.NAMESPACE_SYSTEMUI,
|
|
SystemUiDeviceConfigFlags.VOLUME_SEPARATE_NOTIFICATION, "false", false);
|
|
|
|
NotificationVolumePreferenceController controller =
|
|
new NotificationVolumePreferenceController(mContext);
|
|
when(screen.findPreference(controller.getPreferenceKey()))
|
|
.thenReturn(volumeSeekBarPreference);
|
|
|
|
// allow the controller to subscribe
|
|
Shadows.shadowOf((android.app.Application) ApplicationProvider.getApplicationContext())
|
|
.grantPermissions(READ_DEVICE_CONFIG_PERMISSION);
|
|
controller.onResume();
|
|
controller.displayPreference(screen);
|
|
|
|
DeviceConfig.setProperty(DeviceConfig.NAMESPACE_SYSTEMUI,
|
|
SystemUiDeviceConfigFlags.VOLUME_SEPARATE_NOTIFICATION, Boolean.toString(true),
|
|
false);
|
|
|
|
assertThat(controller.getAvailabilityStatus()
|
|
== BasePreferenceController.AVAILABLE).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void disableSeparateNotificationConfig_controllerBecomesUnavailable() {
|
|
PreferenceScreen screen = spy(new PreferenceScreen(mContext, null));
|
|
VolumeSeekBarPreference volumeSeekBarPreference = mock(VolumeSeekBarPreference.class);
|
|
when(screen.getPreferenceManager()).thenReturn(mPreferenceManager);
|
|
when(screen.getContext()).thenReturn(mContext);
|
|
when(mResources.getBoolean(
|
|
com.android.settings.R.bool.config_show_notification_volume)).thenReturn(true);
|
|
|
|
// block the alternative condition to enable controller
|
|
when(mTelephonyManager.isVoiceCapable()).thenReturn(true);
|
|
|
|
DeviceConfig.setProperty(DeviceConfig.NAMESPACE_SYSTEMUI,
|
|
SystemUiDeviceConfigFlags.VOLUME_SEPARATE_NOTIFICATION, "true", false);
|
|
|
|
NotificationVolumePreferenceController controller =
|
|
new NotificationVolumePreferenceController(mContext);
|
|
|
|
when(screen.findPreference(controller.getPreferenceKey()))
|
|
.thenReturn(volumeSeekBarPreference);
|
|
|
|
Shadows.shadowOf((android.app.Application) ApplicationProvider.getApplicationContext())
|
|
.grantPermissions(READ_DEVICE_CONFIG_PERMISSION);
|
|
controller.onResume();
|
|
controller.displayPreference(screen);
|
|
|
|
DeviceConfig.setProperty(DeviceConfig.NAMESPACE_SYSTEMUI,
|
|
SystemUiDeviceConfigFlags.VOLUME_SEPARATE_NOTIFICATION, "false", false);
|
|
|
|
assertThat(controller.getAvailabilityStatus()
|
|
== BasePreferenceController.UNSUPPORTED_ON_DEVICE).isTrue();
|
|
}
|
|
|
|
}
|