**Root cause** Two reasons of the flaky test: - Settings value not reset to default after tests - Need time for the settings value changes to propagate to its listeners Other clean up: When creating a preference, by default it will store values in the shared preferences. If we don't intent to save the preference to the sharedPreferences, we should set presistent as false. Bug: 279818352 Test: atest SettingsUnitTests:com.android.settings.accessibility.DisableAnimationsPreferenceControllerTest#onStart_disabledAnimation_shouldReturnTrue --iterations 50 Change-Id: Ie645f8e847fc8ce188a7e5ed45bf5050f81e1d9a
193 lines
6.8 KiB
Java
193 lines
6.8 KiB
Java
/*
|
|
* Copyright (C) 2020 The Android Open Source Project
|
|
*
|
|
* Licensed under the Apache License, Version 2.0 (the "License");
|
|
* you may not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing, software
|
|
* distributed under the License is distributed on an "AS IS" BASIS,
|
|
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
* See the License for the specific language governing permissions and
|
|
* limitations under the License.
|
|
*/
|
|
|
|
package com.android.settings.accessibility;
|
|
|
|
import static com.android.settings.accessibility.DisableAnimationsPreferenceController.ANIMATION_OFF_VALUE;
|
|
import static com.android.settings.accessibility.DisableAnimationsPreferenceController.ANIMATION_ON_VALUE;
|
|
import static com.android.settings.accessibility.DisableAnimationsPreferenceController.TOGGLE_ANIMATION_TARGETS;
|
|
|
|
import static com.google.common.truth.Truth.assertThat;
|
|
|
|
import android.content.ContentResolver;
|
|
import android.content.Context;
|
|
import android.database.ContentObserver;
|
|
import android.net.Uri;
|
|
import android.os.Handler;
|
|
import android.os.Looper;
|
|
import android.os.UserHandle;
|
|
import android.provider.Settings;
|
|
|
|
import androidx.annotation.Nullable;
|
|
import androidx.preference.PreferenceManager;
|
|
import androidx.preference.PreferenceScreen;
|
|
import androidx.preference.SwitchPreference;
|
|
import androidx.test.core.app.ApplicationProvider;
|
|
import androidx.test.ext.junit.runners.AndroidJUnit4;
|
|
|
|
import com.android.settings.core.BasePreferenceController;
|
|
|
|
import org.junit.After;
|
|
import org.junit.Assert;
|
|
import org.junit.Before;
|
|
import org.junit.Test;
|
|
import org.junit.runner.RunWith;
|
|
|
|
import java.util.concurrent.CountDownLatch;
|
|
import java.util.concurrent.TimeUnit;
|
|
|
|
@RunWith(AndroidJUnit4.class)
|
|
public class DisableAnimationsPreferenceControllerTest {
|
|
|
|
private static final String TEST_PREFERENCE_KEY = "disable_animation";
|
|
private final Context mContext = ApplicationProvider.getApplicationContext();
|
|
private Looper mLooper;
|
|
|
|
private PreferenceScreen mScreen;
|
|
private SwitchPreference mPreference;
|
|
private DisableAnimationsPreferenceController mController;
|
|
|
|
@Before
|
|
public void setUp() {
|
|
if (Looper.myLooper() == null) {
|
|
Looper.prepare();
|
|
}
|
|
mLooper = Looper.myLooper();
|
|
PreferenceManager preferenceManager = new PreferenceManager(mContext);
|
|
mScreen = preferenceManager.createPreferenceScreen(mContext);
|
|
final SwitchPreference preference = new SwitchPreference(mContext);
|
|
preference.setKey(TEST_PREFERENCE_KEY);
|
|
preference.setPersistent(false);
|
|
mScreen.addPreference(preference);
|
|
|
|
mController = new DisableAnimationsPreferenceController(mContext, TEST_PREFERENCE_KEY);
|
|
mController.displayPreference(mScreen);
|
|
mPreference = mScreen.findPreference(TEST_PREFERENCE_KEY);
|
|
}
|
|
|
|
@After
|
|
public void cleanUp() {
|
|
// calling Settings.Global.resetToDefaults doesn't work somehow
|
|
// one could check if it works by running the test ones, and see if the settings
|
|
// that were changed being restored to default
|
|
setAnimationScaleAndWaitForUpdate(ANIMATION_ON_VALUE);
|
|
}
|
|
|
|
@Test
|
|
public void getAvailabilityStatus_shouldReturnAvailable() {
|
|
assertThat(mController.getAvailabilityStatus()).isEqualTo(
|
|
BasePreferenceController.AVAILABLE);
|
|
}
|
|
|
|
@Test
|
|
public void isChecked_enabledAnimation_shouldReturnFalse() {
|
|
setAnimationScaleAndWaitForUpdate(ANIMATION_ON_VALUE);
|
|
|
|
mController.updateState(mPreference);
|
|
|
|
assertThat(mController.isChecked()).isFalse();
|
|
assertThat(mPreference.isChecked()).isFalse();
|
|
}
|
|
|
|
@Test
|
|
public void isChecked_disabledAnimation_shouldReturnTrue() {
|
|
setAnimationScaleAndWaitForUpdate(ANIMATION_OFF_VALUE);
|
|
|
|
mController.updateState(mPreference);
|
|
|
|
assertThat(mController.isChecked()).isTrue();
|
|
assertThat(mPreference.isChecked()).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void setChecked_disabledAnimation_shouldDisableAnimationTargets() {
|
|
mController.setChecked(true);
|
|
|
|
for (String animationSetting : TOGGLE_ANIMATION_TARGETS) {
|
|
final float value = Settings.Global.getFloat(mContext.getContentResolver(),
|
|
animationSetting, /* def= */ -1.0f);
|
|
assertThat(Float.compare(value, ANIMATION_OFF_VALUE)).isEqualTo(0);
|
|
}
|
|
}
|
|
|
|
@Test
|
|
public void setChecked_enabledAnimation_shouldEnableAnimationTargets() {
|
|
mController.setChecked(false);
|
|
|
|
for (String animationSetting : TOGGLE_ANIMATION_TARGETS) {
|
|
final float value = Settings.Global.getFloat(mContext.getContentResolver(),
|
|
animationSetting, /* def= */ -1.0f);
|
|
assertThat(Float.compare(value, ANIMATION_ON_VALUE)).isEqualTo(0);
|
|
}
|
|
}
|
|
|
|
@Test
|
|
public void onStart_enabledAnimation_shouldReturnFalse() {
|
|
mController.onStart();
|
|
|
|
setAnimationScaleAndWaitForUpdate(ANIMATION_ON_VALUE);
|
|
|
|
assertThat(mController.isChecked()).isFalse();
|
|
assertThat(mPreference.isChecked()).isFalse();
|
|
}
|
|
|
|
@Test
|
|
public void onStart_disabledAnimation_shouldReturnTrue() {
|
|
mController.onStart();
|
|
|
|
setAnimationScaleAndWaitForUpdate(ANIMATION_OFF_VALUE);
|
|
|
|
assertThat(mController.isChecked()).isTrue();
|
|
assertThat(mPreference.isChecked()).isTrue();
|
|
}
|
|
|
|
@Test
|
|
public void onStop_shouldNotUpdateTargets() {
|
|
mPreference.setChecked(true);
|
|
mController.onStart();
|
|
mController.onStop();
|
|
|
|
setAnimationScaleAndWaitForUpdate(ANIMATION_ON_VALUE);
|
|
|
|
assertThat(mPreference.isChecked()).isTrue();
|
|
}
|
|
|
|
private void setAnimationScaleAndWaitForUpdate(float newValue) {
|
|
ContentResolver resolver = mContext.getContentResolver();
|
|
CountDownLatch countDownLatch = new CountDownLatch(TOGGLE_ANIMATION_TARGETS.size());
|
|
ContentObserver settingsObserver = new ContentObserver(new Handler(mLooper)) {
|
|
@Override
|
|
public void onChange(boolean selfChange, @Nullable Uri uri) {
|
|
countDownLatch.countDown();
|
|
|
|
}
|
|
};
|
|
|
|
try {
|
|
for (String key : TOGGLE_ANIMATION_TARGETS) {
|
|
resolver.registerContentObserver(Settings.Global.getUriFor(key),
|
|
false, settingsObserver, UserHandle.USER_ALL);
|
|
Settings.Global.putFloat(mContext.getContentResolver(), key,
|
|
newValue);
|
|
}
|
|
countDownLatch.await(5, TimeUnit.SECONDS);
|
|
} catch (InterruptedException e) {
|
|
Assert.fail(e.getMessage());
|
|
} finally {
|
|
resolver.unregisterContentObserver(settingsObserver);
|
|
}
|
|
}
|
|
} |